[[oe] [meta-networking][PATCH 0/2] add new recipes for GeoIP] On 14.12.26 (Fri 14:23) leimaohui wrote:
> GeoIP: allow you to look up information about a given IP address.
> geoipupdate: can download and update the GeoLite Legacy databases.
This looks good over-all but we're really trying to limit the number of
.inc files unless we have an expectation that we'll be maintaining more
than one version of the recipe at the same time. Or, I suppose, if the
recipe is very complex and it could be made clearer by breaking it up
into an include and a recipe file, that might make sense, but I don't
think this falls into either category. Would you mind combining them
and eliminating the .inc file?
While we're here, there's a couple of minor stylistic things. I don't
know exactly what's happening here:
meta-networking/recipes-support/GeoIP/GeoIP_1.6.0.bb:
51 PACKAGES =+ "${PN}-database"
52 FILES_${PN}-database = ""
53 FILES_${PN}-database += "${datadir}/GeoIP/*"
and for this:
28 LIC_FILES_CHKSUM = "\
29 file://COPYING;md5=d5d53d6b948c064f4070183180a4fa89 \
30 file://LICENSE;md5=f04db71812ba70aaba8b38da91984cd2 \
31 "
the usual approach is to either line up the indenting with the first "
or four spaces. I'm okay with either, though four spaces is probably
preferred here and probably do the same for EXTRA_OECONF.
-J.
>
> leimh (2):
> GeoIP: add recipe
> geoipupdate: add new recipe
>
> meta-networking/recipes-support/GeoIP/GeoIP.inc | 10 ++++
> .../recipes-support/GeoIP/GeoIP_1.6.0.bb | 54
> ++++++++++++++++++++++
> .../GeoIP/geoipupdate-2.1.0/GeoIP.conf | 11 +++++
> .../GeoIP/geoipupdate-2.1.0/geoipupdate.cron | 5 ++
> .../recipes-support/GeoIP/geoipupdate_2.1.0.bb | 26 +++++++++++
> 5 files changed, 106 insertions(+)
> create mode 100644 meta-networking/recipes-support/GeoIP/GeoIP.inc
> create mode 100644 meta-networking/recipes-support/GeoIP/GeoIP_1.6.0.bb
> create mode 100644
> meta-networking/recipes-support/GeoIP/geoipupdate-2.1.0/GeoIP.conf
> create mode 100644
> meta-networking/recipes-support/GeoIP/geoipupdate-2.1.0/geoipupdate.cron
> create mode 100644 meta-networking/recipes-support/GeoIP/geoipupdate_2.1.0.bb
>
> --
> 1.9.1
>
--
-Joe MacDonald.
:wq
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
