-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Martin Jansa schreef op 02-03-15 om 11:26: > On Mon, Mar 02, 2015 at 11:22:30AM +0100, Koen Kooi wrote: Martin Jansa > schreef op 02-03-15 om 09:02: >>>> * useful to run our qemu* builds inside VirtualBox >>>> >>>> Signed-off-by: Martin Jansa <[email protected]> --- >>>> .../vboxguestdrivers/Makefile.utils | 43 >>>> ++++++++++++++ .../vboxguestdrivers/vboxguestdrivers_4.3.22.bb | >>>> 65 ++++++++++++++++++++++ > >>>> +PACKAGES += "kernel-module-vboxguest kernel-module-vboxsf >>>> kernel-module-vboxvideo" +RDEPENDS_${PN} += >>>> "kernel-module-vboxguest kernel-module-vboxsf >>>> kernel-module-vboxvideo" > > Please don't ever RDEPEND on kernel modules, even when the recipe will > build them, it sets a bad precedent. > >> I think it makes sense in this case.. nobody will ever include them in >> kernel image and vboxguestdrivers utils don't make much sense without >> the modules installed.
I agree completely with that, my objection is setting a bad precedent that people will copy/paste into other recipes. I see v2 has RRECOMMENDS, thank you for changing it. regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) Comment: GPGTools - http://gpgtools.org iD8DBQFU9XykMkyGM64RGpERAtp/AJ9/M6P16FGCn/EvTXEWCygoon+NHACfWKPA j0bXmjsmVkWxKsJ+e5Ulaog= =H4No -----END PGP SIGNATURE----- -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
