Hi Andre McCurdy, Thank you very much for doing review. I have considered all your suggestions and you can find the re-worked patch http://lists.openembedded.org/pipermail/openembedded-devel/2015-June/101744.html
On 3 June 2015 at 05:05, Andre McCurdy <[email protected]> wrote: > On Mon, Jun 1, 2015 at 7:48 AM, Naresh Bhat <[email protected]> wrote: >> Add xorriso v1.4.0 based on the discussions >> http://patchwork.openembedded.org/patch/91143/ >> http://lists.openembedded.org/pipermail/openembedded-devel/2015-April/100981.html >> We have tested this package with >> Montavista CGE product - http://www.mvista.com/ and >> luvOS distribution - https://01.org/linux-uefi-validation build. >> Inherit the pkgconfig to avoid the below error, >> .. >> ... >> | disabled use of O_DIRECT with input of -as cdrskin >> | luv-yocto/build/tmp/work/aarch64-oe-linux/xorriso/1.4.0-r0/xorriso-1.4.0/ >> configure: line 14352: syntax error near unexpected token `LIBCDIO,' >> | luv-yocto/build/tmp/work/aarch64-oe-linux/xorriso/1.4.0-r0/xorriso-1.4.0/ >> configure: line 14352: ` PKG_CHECK_MODULES(LIBCDIO, libcdio >= >> $LIBCDIO_REQUIRED)' >> ... >> .... >> >> Signed-off-by: Naresh Bhat <[email protected]> >> Signed-off-by: Jagadeesh Krishnanjanappa <[email protected]> >> Signed-off-by: Gaurang Shastri <[email protected]> >> --- >> .../recipes-utils/xorriso/xorriso_1.4.0.bb | 30 >> ++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 meta-filesystems/recipes-utils/xorriso/xorriso_1.4.0.bb >> >> diff --git a/meta-filesystems/recipes-utils/xorriso/xorriso_1.4.0.bb >> b/meta-filesystems/recipes-utils/xorriso/xorriso_1.4.0.bb >> new file mode 100644 >> index 0000000..2f81f0d >> --- /dev/null >> +++ b/meta-filesystems/recipes-utils/xorriso/xorriso_1.4.0.bb >> @@ -0,0 +1,30 @@ >> +DESCRIPTIONS = "xorriso copies file objects from POSIX compliant >> filesystems \ >> +into Rock Ridge enhanced ISO 9660 filesystems and allows session-wise \ >> +manipulation of such filesystems" > > That should be DESCRIPTION, not DESCRIPTIONS. Done. > >> +LICENSE = "GPLv3" >> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" >> + >> +# with, without, depends, rdepends >> +# > > Drop these comments. Thanks, I have removed it. > >> +PACKAGECONFIG ??= "acl attr zlib bzip2 readline" >> +PACKAGECONFIG[acl] = "--enable-libacl,--disable-libacl,acl," >> +PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr," >> +PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib," >> +PACKAGECONFIG[bzip2] = "--enable-libbz2,--disable-libbz2,bzip2," >> +PACKAGECONFIG[readline] = >> "--enable-libreadline,--disable-libreadline,readline," >> + >> +RDEPENDS_${PN} = "tk" > > tk depends on the x11 distro feature, so perhaps xorriso should do too? Yes, You are right. I did the necessary changes. > >> +inherit autotools-brokensep pkgconfig >> + >> +SRC_URI = "http://www.gnu.org/software/${BPN}/${BPN}-${PV}.tar.gz"; > > Move nearer to the top of the recipe, after LIC_FILES_CHKSUM. Done. > > See http://www.openembedded.org/wiki/Styleguide Thanks I have looked into it. > >> +do_configure_prepend () { >> + touch NEWS >> +} >> + >> +BBCLASSEXTEND = "native" >> + >> +SRC_URI[md5sum] = "ec79fd2736b8da76e7a870e27cadf6fa" >> +SRC_URI[sha256sum] = >> "0bd1e085015b28c24f57697d6def2fe84517967dc417554c0c3ccf1685ed0e56" > > Move nearer to the top of the recipe, just after SRC_URI. Done. > >> -- >> 1.7.9.5 >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> [email protected] >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
