On 10/27/2015 12:05 PM, Martin Jansa wrote:
I've noticed second revision as well, it's in master-next, but it haven't finished even the automated jenkins build yet and because I don't use qt5 SDK I was hoping that someone else will review them as well. There are 2 formal issues, I've fixed commit message summary to match our guidelines: http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
But both are also missing SOB line, please confirm that I can add your SOB or resend both patches with SOB (and commit message from master-next).
Yes. Feel free to commit it. The changes are mine and the original file is under MIT license and the one below is my real name.
I'll try to be more strict about commit messages next time. The subject seemed so uncomfortably long.
Thanks -- Ivan Sergio Borgonovo http://www.webthatworks.it -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
