On 9 June 2016 at 00:00, Martin Jansa <[email protected]> wrote: > * fixes QA: > qtcharts-5.6.99+5.7.0-beta+gitAUTOINC+8a78184181: qtcharts-examples > rdepends on qtmultimedia, but it isn't a build dependency, missing > qtmultimedia in DEPENDS or PACKAGECONFIG? [build-deps] > > Signed-off-by: Martin Jansa <[email protected]> > --- > recipes-qt/qt5/qtcharts_git.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-qt/qt5/qtcharts_git.bb b/recipes-qt/qt5/qtcharts_git.bb > index 5aaddc9..99d1471 100644 > --- a/recipes-qt/qt5/qtcharts_git.bb > +++ b/recipes-qt/qt5/qtcharts_git.bb > @@ -6,6 +6,6 @@ LIC_FILES_CHKSUM = " \ > file://LICENSE.GPL3;md5=d32239bcb673463ab874e80d47fae504 \ > " > > -DEPENDS += "qtbase qtdeclarative" > +DEPENDS += "qtbase qtdeclarative qtmultimedia" > > SRCREV = "8a781841812a42ed728a76c0dcdcaa6196eac44e" > -- > 2.8.4
Looks good to me. Though qtmultimedia is only needed if the "examples" PACKAGECONFIG is enabled in either qtbase or qtcharts. I wonder if there is a good way to make the dependency conditional on that. Regards, Jonathan -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
