On Fri, Jul 1, 2016 at 1:25 PM, Slater, Joseph <[email protected]> wrote:
> > -----Original Message----- > > From: [email protected] [mailto: > openembedded-devel- > > [email protected]] On Behalf Of Christopher Larson > > Sent: Thursday, June 30, 2016 10:13 PM > > To: Openembedded Discussion > > Subject: Re: [oe] [meta-networking][PATCH 1/1] openconnect: > PACKAGECONFIG certain > > dependencies > > > > On Thu, Jun 30, 2016 at 12:46 PM, Joe Slater <[email protected]> > wrote: > > > > > +PACKAGECONFIG ??= "gnutls lz4 libproxy" > > > + > > > +# config defaults > > > +PACKAGECONFIG[gnutls] = ",--without-gnutls,gnutls," > > > +PACKAGECONFIG[lz4] = ",--without-lz4,lz4," > > > +PACKAGECONFIG[libproxy] = ",--without-libproxy,libproxy," > > > + > > > +# not config defaults > > > +PACKAGECONFIG[pcsc-lite] = ",--without-libpcsclite,pcsc-lite," > > > > > > > Why are the options not being passed for the enabled case, here? We > prefer > > to be explicit, rather than relying on defaults. > > I can easily add them. I left them out because configure help only > mentions the --without > options to override the defaults. It'd be best to add them, then we're explicitly specifying what we want, and potentially avoid issues if the upstream default behavior changes during an upgrade in the future. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
