Don't resend, it's already in master-next (all 4 squashed into one) and I would keep the space before \ because we always use space before \ even when it's not really necessary.
On Thu, Aug 18, 2016 at 8:09 PM, Robert P. J. Day <[email protected]> wrote: > On Thu, 18 Aug 2016, Khem Raj wrote: > > > > > > On Aug 18, 2016, at 2:37 AM, Robert P. J. Day <[email protected]> > wrote: > > > > > > > > > Signed-off-by: Robert P. J. Day <[email protected]> > > > > > > --- > > > > > > again, not compile-tested since it seems obvious > > > > > > diff --git a/meta-oe/recipes-devtools/php/php.inc > b/meta-oe/recipes-devtools/php/php.inc > > > index ee7a143..23de2b1 100644 > > > --- a/meta-oe/recipes-devtools/php/php.inc > > > +++ b/meta-oe/recipes-devtools/php/php.inc > > > @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/ > php-${PV}.tar.bz2 \ > > > file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch > \ > > > " > > > > > > -SRC_URI_append_class-target += " \ > > > +SRC_URI_append_class-target = “ \ > > > > nitpick: You do not need a space here since its already added after > newline > > since i did that more than once, i'll resubmit those patches. if i'm > going to be annoyingly nitpicky, i might as well do it correctly. > > rday > > -- > > ======================================================================== > Robert P. J. Day Ottawa, Ontario, CANADA > http://crashcourse.ca > > Twitter: http://twitter.com/rpjday > LinkedIn: http://ca.linkedin.com/in/rpjday > ======================================================================== > > -- > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
