> the email subject should mention which layer you want it applied to (though one can determine it based on context, best practice is to include it).
>From the path starting with meta/ it looks like oe-core, then it needs to be sent to openembedded-core ML, not openembedded-devel. On Wed, Dec 28, 2016 at 10:43 PM, Martin Jansa <[email protected]> wrote: > > > On Wed, Dec 28, 2016 at 7:31 PM, Moritz Fischer <[email protected]> > wrote: > >> Add a recipe to build 'ectool', a utility to interact with the embedded >> controller on Google's Chromebooks (and other platforms using it). >> >> Signed-off-by: Moritz Fischer <[email protected]> >> --- >> .../chromium-utils/chromium-utils.bb | 26 >> ++++++++++++++++++++++ >> .../0001-build-Add-HOST_LDFLAGS.patch | 26 >> ++++++++++++++++++++++ >> 2 files changed, 52 insertions(+) >> create mode 100644 meta/recipes-devtools/chromium-utils/ >> chromium-utils.bb >> create mode 100644 meta/recipes-devtools/chromium >> -utils/chromium-utils/0001-build-Add-HOST_LDFLAGS.patch >> >> diff --git a/meta/recipes-devtools/chromium-utils/chromium-utils.bb >> b/meta/recipes-devtools/chromium-utils/chromium-utils.bb >> new file mode 100644 >> index 0000000..c351717 >> --- /dev/null >> +++ b/meta/recipes-devtools/chromium-utils/chromium-utils.bb >> @@ -0,0 +1,26 @@ >> +DESCRIPTION = "Chromium EC utilities" >> > > Use SUMMARY for short description like this. > > >> +DEPENDS = "libftdi" >> +LICENSE = "BSD-3-Clause" >> +LIC_FILES_CHKSUM = "file://LICENSE;md5=562c740877935f40b262db8af30bca36" >> + >> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:" >> > > Why is this needed? > > >> + >> +SRCREV = "b19bb1f22a3fd0102030485d324c0321a18827e8" >> +SRC_URI = "git://chromium.googlesource.com/chromiumos/platform/ec;prot >> ocol=https \ >> + file://0001-build-Add-HOST_LDFLAGS.patch \ >> + " >> + >> +PV="1.1.9999-${SRCPV}" >> > > We usually use something like: > PV = "1.1.9999+gitr${SRCPV}" > > + >> +S = "${WORKDIR}/git" >> + >> +do_compile() { >> + oe_runmake HOSTCC="${CC}" HOSTCFLAGS="${CFLAGS}" >> HOST_LDFLAGS="${LDFLAGS}" utils >> > > Why not use EXTRA_OEMAKE for these added variables? > > >> +} >> + >> +do_install() { >> + install -m 0755 -d ${D}${bindir} >> + install -m 0755 ${S}/build/bds/util/ectool ${D}${bindir}/ectool >> +} >> + >> +FILES_${PN} = "${bindir}" >> diff --git >> a/meta/recipes-devtools/chromium-utils/chromium-utils/0001-build-Add-HOST_LDFLAGS.patch >> b/meta/recipes-devtools/chromium-utils/chromium-utils/0001- >> build-Add-HOST_LDFLAGS.patch >> new file mode 100644 >> index 0000000..46e8cad >> --- /dev/null >> +++ b/meta/recipes-devtools/chromium-utils/chromium-utils/0001- >> build-Add-HOST_LDFLAGS.patch >> @@ -0,0 +1,26 @@ >> +From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001 >> +From: Moritz Fischer <[email protected]> >> +Date: Tue, 27 Dec 2016 22:24:07 -0800 >> +Subject: [PATCH] build Add HOST_LDFLAGS >> + >> +Signed-off-by: Moritz Fischer <[email protected]> >> +--- >> + Makefile.rules | 2 +- >> + 1 file changed, 1 insertion(+), 1 deletion(-) >> + >> +diff --git a/Makefile.rules b/Makefile.rules >> +index 404454d..0057ba9 100644 >> +--- a/Makefile.rules >> ++++ b/Makefile.rules >> +@@ -60,7 +60,7 @@ cmd_c_to_build = $(BUILDCC) $(BUILD_CFLAGS) \ >> + $(sort $(foreach c,$($(*F)-objs),util/$(c:%.o=%.c)) >> $*.c) \ >> + $(BUILD_LDFLAGS) \ >> + -MMD -MF [email protected] -o $@ >> +-cmd_c_to_host = $(HOSTCC) $(HOST_CFLAGS) -MMD -MF [email protected] -o $@ \ >> ++cmd_c_to_host = $(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS) -MMD -MF [email protected] >> -o $@ \ >> + $(sort $(foreach c,$($(*F)-objs),util/$(c:%.o=%.c)) >> $*.c) >> + cmd_cxx_to_host = $(HOSTCXX) -std=c++0x $(COMMON_WARN) $(HOST_CXXFLAGS)\ >> + -I ./$($(notdir $@)_ROOT) -o $@ $(filter %.cc,$^) $($(notdir >> $@)_LIBS) >> +-- >> +2.4.11 >> + >> -- >> 2.7.4 >> >> > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
