Overall, it seems like there are bigger issues to worry about.  I just want
consistency.  I'm willing to conform to whatever people want.

On Mar 3, 2018 12:19 AM, "Tim Orling" <ticot...@gmail.com> wrote:

> I usually would have said “the copyright year changed, but the terms
> remain the same”, but I agree we need consistency. Tooling to make the
> license diff easy to generate is probably the key (and is in progress).
>
> Thank you again, Derek, for all your efforts to keep meta-python up to
> date.
>
> And thank you to Khem for taking the time to review and comment when few
> others ever do.
>
> On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <de...@asterius.io> wrote:
>
>> This is the exact same commit message I've used at least 10s of times
>> without any negative feedback.  Saying the terms remain the same seems
>> sufficient to me to acknowledge the fact I looked at the license and it
>> was
>> reviewed as you stated.  I can start putting the diff in the commit if it
>> adds value but let's start being consistent as a community in what we
>> expect.
>>
>> Even as a maintainer of several layers in meta-openembedded I don't know
>> what we as a community expect...
>>
>> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.k...@gmail.com> wrote:
>>
>> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <de...@asterius.io> wrote:
>> > What more would you like in the commit message?  The license terms are
>> the
>> > same; the copyright moved to 2018.  Do we really need to put the results
>> of
>> > the diff in the commit message?
>> >
>>
>> Not strictly, but you can. In general a line or two about the reason
>> is always a good thing.
>> The commit message wasn't clear about it.
>> This is essentially to let users as well as reviewers know that license
>> changes
>> were reviewed and a line in commit message is there for later to go back
>> and see what changed
>>
>>
>> >
>> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.k...@gmail.com> wrote:
>> >
>> > On 3/2/18 6:06 AM, Derek Straka wrote:
>> >> Update the license checksum and verify the terms remain the same
>> >>
>> >> Signed-off-by: Derek Straka <de...@asterius.io>
>> >> ---
>> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>  | 6
>> >> +++---
>> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}
>> | 0
>> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}
>> | 0
>> >>  3 files changed, 3 insertions(+), 3 deletions(-)
>> >>  rename meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.
>> 15.bb
>> >> => python-sqlalchemy_1.1.17.bb} (100%)
>> >>  rename meta-python/recipes-devtools/python/{python3-sqlalchemy_1.
>> 1.15.bb
>> >> => python3-sqlalchemy_1.1.17.bb} (100%)
>> >>
>> >> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> index 2683a6a..0c191ae 100644
>> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
>> Relational
>> >> Mapper that gives \
>> >>  application developers the full power and flexibility of SQL"
>> >>  HOMEPAGE = "http://www.sqlalchemy.org/";
>> >>  LICENSE = "MIT"
>> >> -LIC_FILES_CHKSUM = "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf5
>> 38"
>> >> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22
>> bb"
>> >>
>> >
>> > what changed here ?
>> >
>> >
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Reply via email to