Can we make the default not be infinite timeout? You are solving a corner case, special need with a default infinite timeout that may have unforeseen side effects in the general case (like a system that never responds). Just a thought. What does upstream think? On Tue, Mar 6, 2018 at 5:18 PM Hongxu Jia <[email protected]> wrote:
> This large timeout is needed when running on machines with > lots of disks, or with slow disks. > > Signed-off-by: Hongxu Jia <[email protected]> > --- > .../0014-invoking-dd-with-infinite-timeout.patch | 31 > ++++++++++++++++++++++ > .../python-blivet/python3-blivet_2.2.0.bb | 1 + > 2 files changed, 32 insertions(+) > create mode 100644 > meta-python/recipes-extended/python-blivet/python3-blivet/0014-invoking-dd-with-infinite-timeout.patch > > diff --git > a/meta-python/recipes-extended/python-blivet/python3-blivet/0014-invoking-dd-with-infinite-timeout.patch > b/meta-python/recipes-extended/python-blivet/python3-blivet/0014-invoking-dd-with-infinite-timeout.patch > new file mode 100644 > index 0000000..12a9e4f > --- /dev/null > +++ > b/meta-python/recipes-extended/python-blivet/python3-blivet/0014-invoking-dd-with-infinite-timeout.patch > @@ -0,0 +1,31 @@ > +From 92fe7dfd01131c93a9b2013cabf77d5f46900fab Mon Sep 17 00:00:00 2001 > +From: Hongxu Jia <[email protected]> > +Date: Tue, 6 Mar 2018 17:28:56 +0800 > +Subject: [PATCH] invoking dd with infinite timeout > + > +This large timeout is needed when running on machines with > +lots of disks, or with slow disks. > + > +Upstream-Status: Pending > + > +Signed-off-by: Hongxu Jia <[email protected]> > +--- > + blivet/devices/partition.py | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/blivet/devices/partition.py b/blivet/devices/partition.py > +index a7372fb..8947472 100644 > +--- a/blivet/devices/partition.py > ++++ b/blivet/devices/partition.py > +@@ -594,7 +594,7 @@ class PartitionDevice(StorageDevice): > + cmd = ["dd", "if=/dev/zero", "of=%s" % device, "bs=%d" % bs, > + "seek=%d" % start, "count=%d" % count] > + try: > +- util.run_program(cmd) > ++ util.run_program(cmd, timeout=-1) > + except OSError as e: > + log.error(str(e)) > + finally: > +-- > +1.8.3.1 > + > diff --git a/meta-python/recipes-extended/python-blivet/ > python3-blivet_2.2.0.bb b/meta-python/recipes-extended/python-blivet/ > python3-blivet_2.2.0.bb > index cacca67..46dc32d 100644 > --- a/meta-python/recipes-extended/python-blivet/python3-blivet_2.2.0.bb > +++ b/meta-python/recipes-extended/python-blivet/python3-blivet_2.2.0.bb > @@ -23,6 +23,7 @@ SRC_URI = "git:// > github.com/rhinstaller/blivet;branch=2.2-devel \ > file://0011-invoking-fsck-with-infinite-timeout.patch \ > file://0012-invoking-mkfs-with-infinite-timeout.patch \ > file://0013-Revert-Adapt-to-logging-module-name-change.patch \ > + file://0014-invoking-dd-with-infinite-timeout.patch \ > " > > inherit distro_features_check > -- > 1.8.3.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
