Hi Khem,
thank you for your feedback!
On 05/22/2018 08:17 PM, Khem Raj wrote:
On Tue, May 22, 2018 at 8:25 AM, Richard Leitner
<richard.leit...@skidata.com> wrote:
Add recipe for uhubctl v2.0.0, an utility to control USB power per-port
on "smart" USB hubs.
Signed-off-by: Richard Leitner <richard.leit...@skidata.com>
---
...001-Makefile-set-program-version-to-2.0.0.patch | 34 ++++++++++++++++++++++
meta-oe/recipes-support/uhubctl/uhubctl_2.0.0.bb | 22 ++++++++++++++
2 files changed, 56 insertions(+)
create mode 100644
meta-oe/recipes-support/uhubctl/files/0001-Makefile-set-program-version-to-2.0.0.patch
create mode 100644 meta-oe/recipes-support/uhubctl/uhubctl_2.0.0.bb
diff --git
a/meta-oe/recipes-support/uhubctl/files/0001-Makefile-set-program-version-to-2.0.0.patch
b/meta-oe/recipes-support/uhubctl/files/0001-Makefile-set-program-version-to-2.0.0.patch
new file mode 100644
index 000000000..e9e06bc71
--- /dev/null
+++
b/meta-oe/recipes-support/uhubctl/files/0001-Makefile-set-program-version-to-2.0.0.patch
can we do it via some other means ? may be via sed or some such and use ${PV}
be used instead of hardcoding version.
You're right... a sed using ${PV} is cleaner and will avoid modifying
the patch on each recipe update. I'll do that in a v2.
+
diff --git a/meta-oe/recipes-support/uhubctl/uhubctl_2.0.0.bb
b/meta-oe/recipes-support/uhubctl/uhubctl_2.0.0.bb
new file mode 100644
index 000000000..80fc92332
--- /dev/null
+++ b/meta-oe/recipes-support/uhubctl/uhubctl_2.0.0.bb
@@ -0,0 +1,22 @@
+SUMMARY = "USB hub per-port power control"
+HOMEPAGE = "https://github.com/mvp/uhubctl";
+BUGTRACKER = "https://github.com/mvp/uhubctl/issues";
+DEPENDS = "libusb1"
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "\
+ https://github.com/mvp/${PN}/archive/v${PV}.tar.gz \
+ file://0001-Makefile-set-program-version-to-2.0.0.patch \
+ "
+SRC_URI[md5sum] = "5c711911d766d76813333c3812277574"
+SRC_URI[sha256sum] =
"4c31278b2c03e5be5a696c3088bc86cf2557a70e00f697799c163aba18e3c40e"
+
+S = "${WORKDIR}/${PN}-${PV}"
+
this looks redundant.
Indeed... it is :-). I'll remove it in v2.
+do_install () {
+ oe_runmake install DESTDIR=${D}
+}
+
do we need this ?
Yes. Otherwise the uhubctl binary won't get installed anywhere (except
the build inside ${S}) and therefore no package is created.
+FILES_${PN} = "${sbindir}/uhubctl"
Do we need this ?
Nope... I'll remove it in v2.
regards;Richard.L
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
