On Sun, Jul 8, 2018 at 11:58 PM Peter Kjellerstedt <[email protected]> wrote: > > > -----Original Message----- > > From: [email protected] > > [mailto:[email protected]] On Behalf Of > > Yu, Mingli > > Sent: den 9 juli 2018 08:37 > > To: Peter Kjellerstedt <[email protected]>; Khem Raj > > <[email protected]> > > Cc: openembeded-devel <[email protected]> > > Subject: Re: [oe] [meta-oe][PATCH] iozone3: Upgrade to 482 > > > > On 2018年07月09日 14:37, Peter Kjellerstedt wrote: > > >> -----Original Message----- > > >> From: [email protected] > > >> [mailto:[email protected]] On Behalf > > Of > > >> Khem Raj > > >> Sent: den 9 juli 2018 06:02 > > >> To: Yu, Mingli <[email protected]> > > >> Cc: openembeded-devel <[email protected]> > > >> Subject: Re: [oe] [meta-oe][PATCH] iozone3: Upgrade to 482 > > >> > > >> On Sun, Jul 8, 2018 at 7:29 PM Yu, Mingli <[email protected]> > > >> wrote: > > >>> On 2018年07月06日 23:01, Khem Raj wrote: > > >>>> On Fri, Jul 6, 2018 at 2:27 AM Yu, Mingli > > <[email protected]> > > >>> wrote: > > >>>>> On 2018年07月06日 00:00, Khem Raj wrote: > > >>>>>> On Wed, Jul 4, 2018 at 11:54 PM <[email protected]> wrote: > > >>>>>>> > > >>>>>>> From: Mingli Yu <[email protected]> > > >>>>>>> > > >>>>>>> Update LIC_FILES_CHKSUM as the file iozone.c > > >>>>>>> used for LIC_FILES_CHKSUM updated > > >>>>>>> > > >>>>>> > > >>>>>> Please describe what has changed that is causing the checksums > > to > > >>>>>> change. > > >>>>> > > >>>>> The source file iozone.c changed has causing the checksum change. > > >>>>> I have already mention it in the commit message. > > >>>> > > >>>> Commit message does not say what changed, We already know > > >>>> something has changed thats causing the checksum change but here > > we > > >>>> usually document what changed specifically, purpose is to let > > users > > >>>> know of any change in licensing requirements that they need to be > > >>>> aware of > > >>> > > >>> Thanks Khem! > > >>> > > >>> I will try to list the changes in V2 but actually the file iozone.c > > >>> used for checksum is source file. It has so much code changes > > unlike > > >>> some packages use COPYRIGHT file or README.md file for checksum. > > >> > > >> Ok that’s probably not ideal then. It would be better to just use > > the > > >> needed lines from checksum > > > > > > Please note that it is only line 37-48 and 260-266 of iozone.c that > > are used > > > to calculate the checksums. However, I guess that that due to the > > fact there > > > is source in between line 48 and 260, some lines have been > > added/removed, so > > > that the line numbers used in the checksum calculation are now off > > (or they > > > were off already before). Looking at the current source, my guess is > > that > > > lines 260-266 should be changed to 269-275. > > > > > > > > Someone should really ask upstream to include a LICENSE file.... > > > > Thanks Peter! > > > > It's better to include a LICENSE file. > > > > But now, how about just use 37-48 lines to calculate the checksum? > > > > Hi Khem, > > What's your opinion? > > > > Thanks, > > The problem is that the license information is really at lines 269-275. > And at lines 37-48. Which is a mess...
ok. you can have two entries in checksum like we do for multiple license files. -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
