On Thu, Dec 13, 2018 at 11:13 AM Paolo Valente <[email protected]> wrote: > > > > > Il giorno 13 dic 2018, alle ore 18:24, Khem Raj <[email protected]> ha > > scritto: > > > > On Thu, Dec 13, 2018 at 9:20 AM Paolo Valente <[email protected]> > > wrote: > >> > >> > >> > >>> Il giorno 13 dic 2018, alle ore 18:18, Khem Raj <[email protected]> ha > >>> scritto: > >>> > >>> On Thu, Dec 13, 2018 at 9:16 AM Paolo Valente <[email protected]> > >>> wrote: > >>>> > >>>> > >>>> > >>>>> Il giorno 13 dic 2018, alle ore 18:11, Khem Raj <[email protected]> ha > >>>>> scritto: > >>>>> > >>>>> On Thu, Dec 13, 2018 at 7:33 AM Paolo Valente > >>>>> <[email protected]> wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>> Il giorno 13 dic 2018, alle ore 16:27, Khem Raj <[email protected]> > >>>>>>> ha scritto: > >>>>>>> > >>>>>>> On Thu, Dec 13, 2018 at 7:16 AM Paolo Valente > >>>>>>> <[email protected]> wrote: > >>>>>>>> > >>>>>>>> Signed-off-by: Paolo Valente <[email protected]> > >>>>>>>> --- > >>>>>>>> meta-oe/recipes-benchmark/s-suite/s-suite_git.bb | 5 +++-- > >>>>>>>> 1 file changed, 3 insertions(+), 2 deletions(-) > >>>>>>>> > >>>>>>>> diff --git a/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb > >>>>>>>> b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb > >>>>>>>> index 77d172814..166f3000a 100644 > >>>>>>>> --- a/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb > >>>>>>>> +++ b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb > >>>>>>>> @@ -2,7 +2,7 @@ SUMMARY = "Small collection of benchmarks for > >>>>>>>> storage I/O" > >>>>>>>> LICENSE = "GPLv2" > >>>>>>>> LIC_FILES_CHKSUM = > >>>>>>>> "file://COPYING;md5=b529aaa6a0c50f15d29f89609b5c22f3" > >>>>>>>> > >>>>>>>> -SRCREV = "79698f645bfb28d0d966484ddad3a1efb562246d" > >>>>>>>> +SRCREV = "e2727f70ed79b5461689c062a4a66a87f1adb4ce" > >>>>>>>> PV = "0.0+git${SRCPV}" > >>>>>>>> SRC_URI = > >>>>>>>> "git://github.com/Algodev-github/S.git;protocol=https;branch=master" > >>>>>>>> > >>>>>>>> @@ -21,7 +21,8 @@ do_install() { > >>>>>>>> install -m0755 ${S}/def_config_params.sh ${D}/opt/S-suite > >>>>>>>> } > >>>>>>>> > >>>>>>>> -RDEPENDS_${PN} = "bash bc coreutils gawk g++ gcc fio libaio > >>>>>>>> libaio-dev sysstat" > >>>>>>>> +RDEPENDS_${PN} = "bash bc coreutils gawk g++ gcc fio libaio > >>>>>>>> libaio-dev sysstat \ > >>>>>>>> + psmisc git" > >>>>>>> > >>>>>>> why these new rdeps > >>>>>> > >>>>>> psmisc is for killall, git is for ... git :) > >>>>> > >>>>> I think busybox provides killall too. > >>>> > >>>> Ok, I'll remove this dep. > >>>> > >>>>>> > >>>>>> Some weeks ago, I bumped into this missing dependencies that made the > >>>>>> automatic execution of a test fail on a system without either killall > >>>>>> or git. > >>>>> > >>>>> OK. so I wonder if we dont have killall enabled in oe-core by default in > >>>>> busybox ? or does it need ps-misc one specifically ? > >>>>> > >>>>> git is interesting, does it clone some sources during executing tests ? > >>>>> > >>>> In kernel-task benchmarks a mainline Linux is cloned. But maybe such > >>>> benchmarks do not make sense in oe. Let me know, and I'll remove this > >>>> dep too. > >>> > >>> they are fine. We just need to understand that they are well meaning > >>> changes. > >>> > >> > >> So, is the patch ok, or shall I remove the psmisc dep? > > > > I think it will be good to understand why killall went missing without > > ps-misc package. As such patch is ok. Since I think killall should always > > be there, either from ps-misc or a backfill from busybox. > > > > Sorry, I created a lot of confusion. > > 1) killall *was not* missing in any of the oe rootfs that I tested > (rootfs made by Anders, in CC). killall was missing on a non-oe > remote machine, made available for my tests by a company. So, I added > that dependency (in my S suite) to make it work on that machine. For > this reason, I thought of adding this dependency to this recipe. But, > if it is not needed, I'll remove it.
ok lets remove it > > 2) git is needed only if you want to run kernel-development tests. > lets keep it. > That said, just tell me whether the patch is ok, or tell me what > dependencies to remove, and I'll make a V2. yes please. > > Thanks, > Paolo > > >> > >> Thanks, > >> Paolo > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
