Hi Alex: I got it. My previous patch is a little inappropriate. So, I will only include dnf-plugin-tui as a single recipe in my v2 patch, is that OK? If users want to add dnf-plugin-tui to their target or SDK, they can modify their recipe file by themselves.
dnf-plugin-tui can provide an text-based user interface for dnf instead of command line and desktop. - By dnf-plugin-tui, you can use a manifest file to install/remove/upgrade packages. - By nativesdk-dnf-plugin-tui, users can customize image. - By dnf-plugin-tui, users can generate images in various formats, such as JFFS2, INITRAMFS, SquashFS image and so on(Please reference to https://github.com/ubinux/dnf-plugin-tui/blob/master/README.md). - By nativesdk-dnf-plugin-tui, users can manage srpm packages and SPDX files. -------------------------------------------------- Zheng Ruoqin Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) ADDR.: No.6 Wenzhu Road, Software Avenue, Nanjing, 210012, China MAIL : [email protected] > -----Original Message----- > From: Alexander Kanavin [mailto:[email protected]] > Sent: Wednesday, April 03, 2019 4:32 PM > To: Zheng, Ruoqin/郑 若钦 <[email protected]> > Cc: OpenEmbedded Devel List <openembedded- > [email protected]> > Subject: Re: [oe] [meta-oe][patch] dnf-plugin-tui: new recipe > > Apologies, but i have to say no to this patch. > > 1) Most people do not want dnf tooling in their SDKs. Your patches include > that > unconditionally. > 2) bbappends do not belong in meta-oe, as they modify behavior of original > recipes quietly when you enable that layer. You need to modify the original > recipes, and send patches for that. > 3) The recipe for the tui plugin should not be nativesdk-specific. If someone > wants that on target, they should be able to. > 4) You had previously submitted this to oe-core, it was discussed, and the > outcome was that it's better to add generic tooling support to eSDK for the > use > case (customizing a rootfs). Meta-oe is not the right place for a > dnf/rpm-specific > solution, especially if it's forced on everyone. > > I would suggest that you make your own layer for this (e.g. > meta-dnf-tui) and publish that in github next to the tui plugin. > > Alex > > > > > On Wed, 3 Apr 2019 at 07:08, Zheng Ruoqin <[email protected]> > wrote: > > > > A new recipe for dnf-plugin called tui. > > This plugin can work in nativesdk environment, and provide some additional > functions: > > 1. Add new command dnf tui --init to make dnf to work on host 2. > > Text-based user interface for dnf. > > 3. Manage SPDX files > > 4. Manage SRPM files > > 5. Add installation samples for dnf > > > > More details, please reference to https://github.com/ubinux/dnf-plugin- > tui/tree/master. > > > > In addition, modify some nativesdk recipes to include dnf-plugin-tui in > > meta- > toolchain. > > > > Signed-off-by: Zheng Ruoqin <[email protected]> > > --- > > .../recipes-core/meta/meta-environment.bbappend | 3 +++ > > .../nativesdk-packagegroup-sdk-host.bbappend | 2 ++ > > .../recipes-devtools/dnf-plugin-tui/dnf_%.bbappend | 29 > ++++++++++++++++++++++ > > .../dnf-plugin-tui/nativesdk-dnf-plugin-tui.bb | 29 > ++++++++++++++++++++++ > > 4 files changed, 63 insertions(+) > > create mode 100644 > > meta-oe/recipes-core/meta/meta-environment.bbappend > > create mode 100644 > > meta-oe/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bba > > ppend create mode 100644 > > meta-oe/recipes-devtools/dnf-plugin-tui/dnf_%.bbappend > > create mode 100644 > > meta-oe/recipes-devtools/dnf-plugin-tui/nativesdk-dnf-plugin-tui.bb > > > > diff --git a/meta-oe/recipes-core/meta/meta-environment.bbappend > > b/meta-oe/recipes-core/meta/meta-environment.bbappend > > new file mode 100644 > > index 0000000..2ac268f > > --- /dev/null > > +++ b/meta-oe/recipes-core/meta/meta-environment.bbappend > > @@ -0,0 +1,3 @@ > > +create_sdk_files_append() { > > + echo 'export MACHINE_ARCH=${MACHINE_ARCH}' >> $script } > > diff --git > > a/meta-oe/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.b > > bappend > > b/meta-oe/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.b > > bappend > > new file mode 100644 > > index 0000000..9f85825 > > --- /dev/null > > +++ b/meta-oe/recipes-core/packagegroups/nativesdk-packagegroup-sdk-ho > > +++ st.bbappend > > @@ -0,0 +1,2 @@ > > +RDEPENDS_${PN}_append = " nativesdk-dnf-plugin-tui \ > > + nativesdk-createrepo-c" > > diff --git a/meta-oe/recipes-devtools/dnf-plugin-tui/dnf_%.bbappend > > b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf_%.bbappend > > new file mode 100644 > > index 0000000..ce683e4 > > --- /dev/null > > +++ b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf_%.bbappend > > @@ -0,0 +1,29 @@ > > +RDEPENDS_${PN}_class-nativesdk += " \ > > + python3-core \ > > + python3-codecs \ > > + python3-netclient \ > > + python3-email \ > > + python3-threading \ > > + python3-distutils \ > > + python3-logging \ > > + python3-fcntl \ > > + librepo \ > > + python3-shell \ > > + libcomps \ > > + libdnf \ > > + python3-sqlite3 \ > > + python3-compression \ > > + python3-rpm \ > > + python3-iniparse \ > > + python3-json \ > > + python3-curses \ > > + python3-misc \ > > + python3-gpg \ > > + libnewt-python \ > > + " > > + > > +do_install_append_class-nativesdk() { > > + create_wrapper ${D}/${bindir}/dnf \ > > + RPM_CONFIGDIR=${SDKPATHNATIVE}${libdir_nativesdk}/rpm \ > > + RPM_NO_CHROOT_FOR_SCRIPTS=1 } > > diff --git > > a/meta-oe/recipes-devtools/dnf-plugin-tui/nativesdk-dnf-plugin-tui.bb > > b/meta-oe/recipes-devtools/dnf-plugin-tui/nativesdk-dnf-plugin-tui.bb > > new file mode 100644 > > index 0000000..4fbbac8 > > --- /dev/null > > +++ b/meta-oe/recipes-devtools/dnf-plugin-tui/nativesdk-dnf-plugin-tui > > +++ .bb > > @@ -0,0 +1,29 @@ > > +SUMMARY = "A text-based user interface plugin for dnf, used in toolchian > environment" > > +LICENSE = "GPLv2" > > + > > +LIC_FILES_CHKSUM = > "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" > > + > > +SRC_URI = "git://github.com/ubinux/dnf-plugin-tui.git;branch=master " > > + > > +SRCREV = "a743116fa78a20f9828533c1de79ad8e4ab2d16c" > > + > > +inherit nativesdk distutils3-base > > + > > +S = "${WORKDIR}/git" > > + > > +RDEPENDS_${PN} += " \ > > + nativesdk-dnf \ > > + nativesdk-libnewt-python \ > > + " > > + > > +do_install_append() { > > + install -d ${D}${datadir}/dnf > > + install -m 0755 ${S}/samples/* ${D}${datadir}/dnf > > + install -d ${D}${PYTHON_SITEPACKAGES_DIR}/dnf-plugins/mkimg > > + install -m 0755 ${S}/dnf-plugins/mkimg/* > ${D}${PYTHON_SITEPACKAGES_DIR}/dnf-plugins/mkimg > > + for file in $(ls ${S}/dnf-plugins/ | grep -v mkimg); do > > + install -m 0755 ${S}/dnf-plugins/$file > ${D}${PYTHON_SITEPACKAGES_DIR}/dnf-plugins > > + done > > +} > > + > > +FILES_${PN} += "${datadir}/dnf" > > -- > > 2.7.4 > > > > > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > [email protected] > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
