On Thu, Aug 8, 2019 at 6:43 PM Kang Kai <[email protected]> wrote: > > On 2019/8/9 上午5:52, Khem Raj wrote: > > On Thu, Aug 8, 2019 at 2:33 AM <[email protected]> wrote: > >> From: Kai Kang <[email protected]> > >> > >> Because xfce4-settings turn back to its official upstream, it missing > >> function to set date and time. Add it from Andreas's repo on github. > >> It depends on dbus service org.freedesktop.timedate1 which is provided > >> by systemd, so add systemd to RDEPENDS. > >> > >> Signed-off-by: Kai Kang <[email protected]> > >> --- > >> .../xfce4-datetime-setter_3.32.2.bb | 18 ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> create mode 100644 > >> meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb > >> > >> diff --git > >> a/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb > >> > >> b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb > >> new file mode 100644 > >> index 000000000..7a28b6101 > >> --- /dev/null > >> +++ > >> b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb > >> @@ -0,0 +1,18 @@ > >> +DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for > >> XFCE. \ > >> +It is based upon GTK3 and embedds into recent xfce4-settings." > >> +HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"; > >> +LICENSE = "GPLv2" > >> +LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e" > >> + > >> +DEPENDS = "glib-2.0-native libxfce4ui" > >> + > >> +SRC_URI = > >> "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https" > >> +SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f" > >> + > >> +S = "${WORKDIR}/git" > >> + > >> +inherit gettext meson > >> + > >> +FILES_${PN} += "${datadir}/icons/hicolor" > >> + > >> +RDEPENDS_${PN} = "systemd tzdata" > > On systemd-less systems it wont work > > > > ERROR: Nothing RPROVIDES 'systemd' (but > > /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb > > RDEPENDS on or otherwise requires it) > > systemd was skipped: missing required distro feature 'systemd' (not in > > DISTRO_FEATURES) > > It uses functions from dbus service org.freedesktop.timedate1 to set > time and date. Without this dbus service, xfce4-datetime-setter doesn't > work. > And this dbus service is provides by systemd. The alternative is to > require distro feature 'systemd'. But I think RRDEPENDS should be more > proper.
In such cases, it means the package is systemd specific and since we can only have one init system for a distro this package should be guarded with that distro feature as well. rdepends does not know distro nuances. > > Regards, > Kai > > > >> -- > >> 2.20.0 > >> > > -- > Kai Kang > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
