REQUIRED_DISTRO_FEATURES = "x11" doesn't do anything unless you inherit the distro_features_check.bbclass which I don't see in the recipe.
On Thu, Nov 14, 2019 at 11:34 PM Khem Raj <[email protected]> wrote: > On Thu, Nov 14, 2019 at 10:04 AM Leon Anavi <[email protected]> > wrote: > > > > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. > > > > Signed-off-by: Leon Anavi <[email protected]> > > --- > > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > ++++++++++++++++++++++ > > meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 > ++++++++++++++++++ > > 2 files changed, 66 insertions(+) > > create mode 100644 > meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb > > > > diff --git > a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > new file mode 100644 > > index 0000000..a3e33ea > > --- /dev/null > > +++ > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > @@ -0,0 +1,36 @@ > > +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 > > +From: Leon Anavi <[email protected]> > > +Date: Thu, 14 Nov 2019 14:28:39 +0000 > > +Subject: [PATCH] config.mk: Fix compiler and linker > > + > > +Do not set explicitly compiler and linker. > > + > > +Signed-off-by: Leon Anavi <[email protected]> > > +--- > > + config.mk | 6 +++--- > > + 1 file changed, 3 insertions(+), 3 deletions(-) > > + > > +diff --git a/config.mk b/config.mk > > +index df6e812..bf07406 100644 > > +--- a/config.mk > > ++++ b/config.mk > > +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` > > + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` > > + > > + # includes and libs > > +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} > > +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 > > ++INCS = ${GTKINC} > > ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 > > + > > + # flags > > + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" > -D_DEFAULT_SOURCE > > +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} > > + #LDFLAGS = ${LIBS} > > + > > + # compiler and linker > > +-CC = cc > > ++#CC = cc > > +-- > > +2.7.4 > > + > > diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb > b/meta-oe/recipes-graphics/surf/surf_2.0.bb > > new file mode 100644 > > index 0000000..98d3b23 > > --- /dev/null > > +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb > > @@ -0,0 +1,30 @@ > > +SUMMARY = "Simple web browser" > > +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" > > +HOMEPAGE = "https://surf.suckless.org/"; > > +SECTION = "x11/graphics" > > +LICENSE = "MIT" > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" > > + > > +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" > > + > > seems to have sstate issues in do_install see > > http://jenkins.nas-admin.org/job/oe_world_workspace-compare-signatures/846/console > > perhaps due to ./meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb > being in depends and > this recipe is pinned per MACHINE via PACKAGE_ARCH = "${MACHINE_ARCH}" > > > > +REQUIRED_DISTRO_FEATURES = "x11" > > + > > +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ > > + file://0001-config.mk-Fix-compiler-and-linker.patch \ > > +" > > +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" > > + > > +S = "${WORKDIR}/git" > > + > > +inherit pkgconfig > > + > > +TARGET_CC_ARCH += "${LDFLAGS}" > > + > > +do_install () { > > + install -d ${D}${bindir} > > + install -m 0644 ${S}/surf ${D}${bindir} > > + chmod +x ${D}${bindir}/surf > > +} > > + > > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > > +INHIBIT_PACKAGE_STRIP = "1" > > -- > > 2.7.4 > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > [email protected] > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
