On Fri, May 01, 2020 at 09:50:21AM +0200, Jacob Kroon wrote: > On 4/30/20 11:10 PM, Richard Leitner wrote: > > Hi Jacob, > > thanks for the patch! > > > > On Thu, Apr 30, 2020 at 03:15:56PM +0200, Jacob Kroon wrote: > > > Signed-off-by: Jacob Kroon <[email protected]> > > > --- > > > recipes-core/openjdk/openjdk-8-common.inc | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/recipes-core/openjdk/openjdk-8-common.inc > > > b/recipes-core/openjdk/openjdk-8-common.inc > > > index d8b30b8..5228338 100644 > > > --- a/recipes-core/openjdk/openjdk-8-common.inc > > > +++ b/recipes-core/openjdk/openjdk-8-common.inc > > > @@ -176,6 +176,10 @@ FLAGS_GCC6 = "-fno-lifetime-dse > > > -fno-delete-null-pointer-checks" > > > FLAGS_GCC7 = "-fno-lifetime-dse -fno-delete-null-pointer-checks" > > > FLAGS_GCC8 = "-fno-lifetime-dse -fno-delete-null-pointer-checks" > > > FLAGS_GCC9 = "-fno-lifetime-dse -fno-delete-null-pointer-checks" > > > +FLAGS_GCC10 = "-fno-lifetime-dse -fno-delete-null-pointer-checks" > > > + > > > +# GCC 10 defaults to -fno-common, but OpenJDK 8 is not ready for this. > > > +FLAGS_GCC10_append = " -fcommon" > > > > Does setting "-fcommon" also work for GCC version > 5 and < 10? In > > icedtea7-native you've appended it to CFLAGS it w/o GCC version. > > > > Background of the question is that I'm currently planning to drop > > support for GCC versions < 6 in the recipes. If done so, we currently > > have no need for version specific flags. Just want to check if that > > would be an exception. Thanks. > > > > regards;rl > > > > A quick check shows that support for -fcommon/-fno-common exists since at > least gcc 4.7.2: > https://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Code-Gen-Options.html > So yes, it should work for 5 < GCC version < 10.
Great. Thanks for checking. Then I'll take your series as-it-is and will rebase my local patches on yours. regards;rl > > /Jacob
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#84170): https://lists.openembedded.org/g/openembedded-devel/message/84170 Mute This Topic: https://lists.openembedded.org/mt/73374911/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/leave/8024792/1994799631/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
