Hi Tim,

On 10.06.20 г. 8:18 ч., Tim Orling wrote:


On Tue, Jun 9, 2020 at 6:43 AM Leon Anavi <[email protected] <mailto:[email protected]>> wrote:

    Upgrade to release 2.0.1.


I would like to see more information in the commit message for major version upgrades (or any upgrades for that matter).

If you simply go to the source and look for Changelog or similar and copy paste it takes 10-30 seconds and adds a lot of value for quickly reviewing.

Not picking on you, but the nearly empty commit messages on upgrades are not doing any of us any favors. It is simply bad practice and if we had patchtest running on meta-OpenEmbedded these would get Nacked.
Noted. Thank you for the feedback. I've submitted with version 2 of the patch with summary of the changelog. I will keep doing this in future for other similar major version upgrades.

Best regards,
Leon



    Signed-off-by: Leon Anavi <[email protected]
    <mailto:[email protected]>>
    ---
     ...{python3-soupsieve_1.9.4.bb
    <http://python3-soupsieve_1.9.4.bb> => python3-soupsieve_2.0.1.bb
    <http://python3-soupsieve_2.0.1.bb>} | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
     rename
    meta-python/recipes-devtools/python/{python3-soupsieve_1.9.4.bb
    <http://python3-soupsieve_1.9.4.bb> => python3-soupsieve_2.0.1.bb
    <http://python3-soupsieve_2.0.1.bb>} (65%)

    diff --git
    a/meta-python/recipes-devtools/python/python3-soupsieve_1.9.4.bb
    <http://python3-soupsieve_1.9.4.bb>
    b/meta-python/recipes-devtools/python/python3-soupsieve_2.0.1.bb
    <http://python3-soupsieve_2.0.1.bb>
    similarity index 65%
    rename from
    meta-python/recipes-devtools/python/python3-soupsieve_1.9.4.bb
    <http://python3-soupsieve_1.9.4.bb>
    rename to
    meta-python/recipes-devtools/python/python3-soupsieve_2.0.1.bb
    <http://python3-soupsieve_2.0.1.bb>
    index df69e007f..aa087c920 100644
    ---
    a/meta-python/recipes-devtools/python/python3-soupsieve_1.9.4.bb
    <http://python3-soupsieve_1.9.4.bb>
    +++
    b/meta-python/recipes-devtools/python/python3-soupsieve_2.0.1.bb
    <http://python3-soupsieve_2.0.1.bb>
    @@ -4,8 +4,8 @@ HOMEPAGE = "https://github.com/facelessuser/soupsieve";
     LICENSE = "MIT"
     LIC_FILES_CHKSUM =
    "file://LICENSE.md;md5=5a6fd3b0c24fc5a041a3d1bbb22c81b5"

    -SRC_URI[md5sum] = "43d8ea20c58494446aa65ba5cc6320fe"
    -SRC_URI[sha256sum] =
    "605f89ad5fdbfefe30cdc293303665eff2d188865d4dbe4eb510bba1edfbfce3"
    +SRC_URI[md5sum] = "62a7481c7dbf6d8cc21e4e3a79c72034"
    +SRC_URI[sha256sum] =
    "a59dc181727e95d25f781f0eb4fd1825ff45590ec8ff49eadfd7f1a537cc0232"

     inherit pypi setuptools3

-- 2.17.1

--
Leon Anavi
Software Engineer
konsulko.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#84934): 
https://lists.openembedded.org/g/openembedded-devel/message/84934
Mute This Topic: https://lists.openembedded.org/mt/74774158/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to