On Sat, Jun 20, 2020 at 1:08 PM Peter Kjellerstedt <[email protected]> wrote: > > > -----Original Message----- > > From: [email protected] <openembedded- > > [email protected]> On Behalf Of Khem Raj > > Sent: den 19 juni 2020 18:05 > > To: Andreas Müller <[email protected]> > > Cc: openembeded-devel <[email protected]> > > Subject: Re: [oe] [PATCH 10/10] libgit2: upgrade 1.0.0 -> 1.0.1 / rename > > recipe > > > > On 6/19/20 8:55 AM, Andreas Müller wrote: > > > On Fri, Jun 19, 2020 at 5:48 PM Khem Raj <[email protected]> wrote: > > >> > > >> > > >> > > >> On 6/19/20 4:32 AM, Andreas Müller wrote: > > >>> Signed-off-by: Andreas Müller <[email protected]> > > >>> --- > > >>> .../libgit2/{libgit2_1.0.0.bb => libgit2_git.bb} | 3 > > ++- > > >> > > >> I think we have been preferring to use PV via recipe names if > > possible. > > >> which this recipe is already doing, is there any benefit of renaming > > it > > >> to _git ? > > > Renaming: > > > * needs extra efforts to create diff while working on a recipe > > > * might cause issues on huge diffs > > > > > > Shall I switch back to old scheme and send V2? > > > > > > > So one easy problem you run into with _git recipes is that SRCREV gets > > updated but PV does not, the issues with renaming recipes is as you > > described and also git history tracking is a bit painful too, I am not > > hard opined either way. > > > > Lets keep the _PV version if its a proper release SRCREV that we are > > jumping to. > > > > > Andreas > > One reason to keep the version in the filename is because you cannot do > versioned bbappends otherwise. I.e., it is not possible to do a > "libgit2_1.0.%.bbappend" if the recipe is called "libgit2_git.bb". > > //Peter OK - will send V2 for the two recipe-rename recipes tonight
Andreas
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#85244): https://lists.openembedded.org/g/openembedded-devel/message/85244 Mute This Topic: https://lists.openembedded.org/mt/74977538/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
