On Mon, Aug 17, 2020 at 9:43 AM Slater, Joseph <[email protected]> wrote: > > Fine with me, but I thought there could be some reason they REALLY want -O. > Assuming it builds, I'll send a V2 >
possible but I doubt it. its perhaps worth asking upstream. > Joe > > -----Original Message----- > From: Khem Raj <[email protected]> > Sent: Thursday, August 13, 2020 3:25 PM > To: Slater, Joseph <[email protected]> > Cc: openembeded-devel <[email protected]>; MacLeod, > Randy <[email protected]> > Subject: Re: [oe] [meta-networking][PATCH 1/1] aoetool: make builds > reproducible > > On Thu, Aug 13, 2020 at 12:40 PM Joe Slater <[email protected]> wrote: > > > > Strip host path infomation out of binaries by not suppressing default > > CFLAGS. > > > > Signed-off-by: Joe Slater <[email protected]> > > --- > > .../aoetools/aoetools/reproducible-build.patch | 12 ++++++++++++ > > .../recipes-support/aoetools/aoetools_36.bb | 1 + > > 2 files changed, 13 insertions(+) > > create mode 100644 > > meta-networking/recipes-support/aoetools/aoetools/reproducible-build.p > > atch > > > > diff --git > > a/meta-networking/recipes-support/aoetools/aoetools/reproducible-build > > .patch > > b/meta-networking/recipes-support/aoetools/aoetools/reproducible-build > > .patch > > new file mode 100644 > > index 000000000..4939ab25c > > --- /dev/null > > +++ b/meta-networking/recipes-support/aoetools/aoetools/reproducible-b > > +++ uild.patch > > @@ -0,0 +1,12 @@ > > +--- a/Makefile > > ++++ b/Makefile > > +@@ -40,7 +40,8 @@ NPERSHELF=16 > > + CONF_SCRIPTS = aoe-discover aoe-interfaces aoe-mkshelf > > +aoe-revalidate aoe-flush aoe-stat PROGS = aoeping aoecfg > > +aoe-sancheck COMMANDS := ${CONF_SCRIPTS} aoe-mkdevs aoe-version > > +coraid-update ${PROGS} -CFLAGS = -Wall -O -g > > ++# We could still override this on the command line. > > ++CFLAGS += -Wall -O -g > > Perhaps use ?= here, since -O will override the default optimization that > bitbake will pass in env > > > + SANCHECKLIBS = -lpthread > > + > > + AOE_PING_OBJ = aoeping.o linux.o > > diff --git a/meta-networking/recipes-support/aoetools/aoetools_36.bb > > b/meta-networking/recipes-support/aoetools/aoetools_36.bb > > index 9b73b442a..60f3dc9b2 100644 > > --- a/meta-networking/recipes-support/aoetools/aoetools_36.bb > > +++ b/meta-networking/recipes-support/aoetools/aoetools_36.bb > > @@ -13,6 +13,7 @@ RRECOMMENDS_${PN} = "kernel-module-aoe" > > SRC_URI = > > "http://sourceforge.net/projects/${BPN}/files/${BPN}/${BPN}-${PV}.tar.gz \ > > file://aoe-stat-no-bashism.patch \ > > file://makefile-add-ldflags.patch \ > > + file://reproducible-build.patch \ > > " > > SRC_URI[md5sum] = "bff30daa988a65f69d4448ce4726a6db" > > SRC_URI[sha256sum] = > > "fb5e2cd0de7644cc1ec04ee3aeb43211cf7445a0c19e13d6b3ed5a8fbdf215ff" > > -- > > 2.24.1 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#86411): https://lists.openembedded.org/g/openembedded-devel/message/86411 Mute This Topic: https://lists.openembedded.org/mt/76174679/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
