On Tue, Aug 25, 2020 at 10:59 AM Martin Jansa <[email protected]> wrote:
>
> OK, I've overlooked that it's from gitlab, but are you sure that gitlab 
> archives aren't re-generated from time to time like the github archives are?
>
> Or are you sure that https://gitlab.com/libeigen/eigen/-/releases are 
> developer uploaded archives? It looks like gitlab creates them automatically:
> https://docs.gitlab.com/ee/user/project/releases/
> like github does with tag archives.
>

while it fixes the issue it is trying to fix, it would be better to
fix the non-deterministic archive issue as well while here, I dont
know if gitlab's archiving is reproducible perhaps a question for
gitlab, but it would be ok to switch to using git fetcher to avoid
that suspicion. What do you think?

> On Tue, Aug 25, 2020 at 6:36 PM Diego Rondini <[email protected]> 
> wrote:
>>
>> Hi Martin,
>>
>> On Tue, Aug 25, 2020 at 5:57 PM Martin Jansa <[email protected]> wrote:
>> >
>> > Doesn't this trigger src-uri-bad QA warning? It would be better to use git 
>> > fetcher.
>>
>> No warning because this is from git*lab*.
>>
>> Also, this the URL of an official release tarball taken from:
>> https://gitlab.com/libeigen/eigen/-/releases
>>
>> See also first comment here:
>> https://patchwork.openembedded.org/patch/161360/
>>
>> Regards,
>> Diego Rondini
>>
>>
>> >
>> > On Tue, Aug 25, 2020 at 5:45 PM Diego <[email protected]> wrote:
>> >>
>> >> Bitbucket is no longer the official home of eigen, which has moved to
>> >> gitlab. Update SRC_URI to download releases from gitlab, fixing:
>> >> WARNING: libeigen-3.3.7-r0 do_fetch: Failed to fetch URL
>> >> https://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2;downloadfilename=libeigen-3.3.7.tar.bz2,
>> >> attempting MIRRORS if available
>> >>
>> >> Signed-off-by: Diego Rondini <[email protected]>
>> >> ---
>> >>  meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb | 8 ++++----
>> >>  1 file changed, 4 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb 
>> >> b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> >> index f638848d1..9c3d962f4 100644
>> >> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> >> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.7.bb
>> >> @@ -4,11 +4,11 @@ HOMEPAGE = "http://eigen.tuxfamily.org/";
>> >>  LICENSE = "MPL-2.0"
>> >>  LIC_FILES_CHKSUM = 
>> >> "file://COPYING.MPL2;md5=815ca599c9df247a0c7f619bab123dad"
>> >>
>> >> -SRC_URI = 
>> >> "https://bitbucket.org/eigen/eigen/get/${PV}.tar.bz2;downloadfilename=${BP}.tar.bz2";
>> >> -SRC_URI[md5sum] = "05b1f7511c93980c385ebe11bd3c93fa"
>> >> -SRC_URI[sha256sum] = 
>> >> "9f13cf90dedbe3e52a19f43000d71fdf72e986beb9a5436dddcd61ff9d77a3ce"
>> >> +SRC_URI = 
>> >> "https://gitlab.com/libeigen/eigen/-/archive/${PV}/eigen-${PV}.tar.bz2";
>> >> +SRC_URI[md5sum] = "b9e98a200d2455f06db9c661c5610496"
>> >> +SRC_URI[sha256sum] = 
>> >> "685adf14bd8e9c015b78097c1dc22f2f01343756f196acdc76a678e1ae352e11"
>> >>
>> >> -S = "${WORKDIR}/eigen-eigen-323c052e1731"
>> >> +S = "${WORKDIR}/eigen-${PV}"
>> >>
>> >>  inherit cmake
>> >>
>> >> --
>> >> 2.26.2
>> >>
>> >>
>
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#86607): 
https://lists.openembedded.org/g/openembedded-devel/message/86607
Mute This Topic: https://lists.openembedded.org/mt/76409333/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to