Hi, On Sun, 25 Apr 2021 at 00:12, Khem Raj <[email protected]> wrote: > > On Sat, Apr 24, 2021 at 2:48 PM Ross Burton <[email protected]> wrote: > > > > To be honest, as this is Arm-specific I'd encourage adding it to > > meta-arm instead of meta-oe. > > I would tend to agree, although there is something to consider it also > means all arm SOCs will have to depend on meta-arm for this recipe > which may not be a bad thing but some BSP layers for ARM based SOCs > are independent
Ok, so I will submit this patch to meta-arm. Clement > > > > > (speaking as the meta-arm co-maintainer) > > > > Ross > > > > On Sat, 24 Apr 2021 at 12:29, Martin Jansa <[email protected]> wrote: > > > > > > Ah, even better than, but I would keep the recipe name as gator, if it's > > > going to completely replace these older gator versions in other layers. > > > > > > On Sat, Apr 24, 2021 at 1:24 PM Clément Péron <[email protected]> > > > wrote: > > >> > > >> Hi Martin, > > >> > > >> On Sat, 24 Apr 2021 at 12:45, Martin Jansa <[email protected]> > > >> wrote: > > >> > > > >> > Why do you want to build only the daemon? > > >> > > > >> > There are already 4 variants of this recipe in various layers (at > > >> > least by what's reported on layerindex): > > >> > http://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro/recipes-kernel/gator/gator_git.bb?h=master > > >> > https://github.com/webosose/meta-webosose/blob/master/meta-webos/recipes-core/gator/gator_git.bb > > >> > https://github.com/kratsg/meta-l1calo/blob/master/recipes-kernel/gator/gator_git.bb > > >> > https://github.com/robseb/meta-intelfpga/blob/master/recipes-devtools/gator/gator_git.bb > > >> > > > >> > so sharing some recipe which would suit most of these needs in meta-oe > > >> > is definitely welcome, but starting with just a daemon will just > > >> > complicate things to these layers. > > >> > > >> New gator daemon doesn't need a kernel module anymore, it's now fully > > >> userspace. > > >> > > >> Regards, > > >> Clement > > >> > > >> > > > >> > But I understand that building the kernel modules for wider range of > > >> > kernels in different MACHINEs is quite pain (been there: > > >> > https://github.com/shr-project/meta-webosose/commit/f4674ac6fa18a0a96cefefa49ebf397a383a88f1 > > >> > and given up shortly after: > > >> > https://github.com/shr-project/meta-webosose/commit/d4bc575623dfbfad780fc39fef47d55d4d6e698d > > >> > as I don't really use gator, it was just one of many build issues in > > >> > 'bitbake world' I was looking at). > > >> > > > >> > Regards, > > >> > > > >> > On Sat, Apr 24, 2021 at 3:29 AM Clément Péron <[email protected]> > > >> > wrote: > > >> >> > > >> >> Hi, > > >> >> > > >> >> I have some questions regarding my patch. > > >> >> > > >> >> On Sat, 24 Apr 2021 at 12:24, Clément Péron <[email protected]> > > >> >> wrote: > > >> >> > > > >> >> > To communicate with the target device, Streamline requires the > > >> >> > gator daemon, gatord, to be running on the device. > > >> >> > > >> >> Is gator the correct name for this package? or would gatord be better? > > >> >> > > >> >> > > > >> >> > Signed-off-by: Clément Péron <[email protected]> > > >> >> > --- > > >> >> > .../gator/0001-gator-don-t-strip-debug.patch | 24 > > >> >> > +++++++++++++++++++ > > >> >> > meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 > > >> >> > +++++++++++++++++ > > >> >> > 2 files changed, 46 insertions(+) > > >> >> > create mode 100644 > > >> >> > meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch > > >> >> > create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb > > >> >> > > > >> >> > diff --git > > >> >> > a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch > > >> >> > > > >> >> > b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch > > >> >> > new file mode 100644 > > >> >> > index 000000000000..8e59fffa1fc2 > > >> >> > --- /dev/null > > >> >> > +++ > > >> >> > b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch > > >> >> > @@ -0,0 +1,24 @@ > > >> >> > +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 > > >> >> > 2001 > > >> >> > +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <[email protected]> > > >> >> > +Date: Fri, 16 Apr 2021 15:27:16 +0200 > > >> >> > +Subject: [PATCH] gator: don't strip debug > > >> >> > + > > >> >> > +--- > > >> >> > + daemon/Makefile | 2 -- > > >> >> > + 1 file changed, 2 deletions(-) > > >> >> > + > > >> >> > +diff --git a/daemon/Makefile b/daemon/Makefile > > >> >> > +index ba5f29cfeb10..6807948310f9 100644 > > >> >> > +--- a/daemon/Makefile > > >> >> > ++++ b/daemon/Makefile > > >> >> > +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut > > >> >> > -f1 -d.` \>= 5),1) > > >> >> > + CXXFLAGS += -fno-sized-deallocation > > >> >> > + endif > > >> >> > + > > >> >> > +-# -s strips the binary of debug info > > >> >> > +-LDFLAGS += -s > > >> >> > + LDLIBS += -lrt -lm -pthread > > >> >> > + TARGET := $(OBJ_DIR)gatord > > >> >> > + ESCAPE_EXE := $(OBJ_DIR)escape/escape > > >> >> > +-- > > >> >> > +2.25.1 > > >> >> > diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb > > >> >> > b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb > > >> >> > new file mode 100644 > > >> >> > index 000000000000..8e15b1ca5fc5 > > >> >> > --- /dev/null > > >> >> > +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb > > >> >> > @@ -0,0 +1,22 @@ > > >> >> > +SUMMARY = "DS-5 Streamine Gator daemon" > > >> >> > +DESCRIPTION = "Target-side daemon gathering data for ARM > > >> >> > Streamline Performance Analyzer." > > >> >> > + > > >> >> > +LICENSE = "GPL-2.0-only" > > >> >> > +LIC_FILES_CHKSUM = > > >> >> > "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" > > >> >> > +LICENSE_libsensors = "LGPL-2.1-or-later" > > >> >> > > >> >> Gator git specifies that: > > >> >> > > >> >> -libsensors source code in daemon/libsensors licensed under > > >> >> LGPL-2.1-or-later > > >> >> -mxml source code in daemon/mxml licensed under APACHE-2.0 WITH > > >> >> Mini-XML-exception > > >> >> -perf_event.h from Linux userspace kernel headers in daemon/k licensed > > >> >> under GPL-2.0-only WITH Linux-syscall-note. > > >> >> > > >> >> I'm not sure how to properly reflect this in the recipe. > > >> >> > > >> >> Thanks for your help, > > >> >> Clement > > >> >> > > >> >> > + > > >> >> > +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f" > > >> >> > +SRC_URI = > > >> >> > "git://github.com/ARM-software/gator.git;protocol=http;branch=master > > >> >> > \ > > >> >> > + file://0001-gator-don-t-strip-debug.patch;patchdir=.. \ > > >> >> > + " > > >> >> > + > > >> >> > +S = "${WORKDIR}/git/daemon" > > >> >> > + > > >> >> > +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} > > >> >> > -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \ > > >> >> > + 'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' > > >> >> > 'CROSS_COMPILE=${TARGET_PREFIX}' \ > > >> >> > + 'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' > > >> >> > CXX='${CXX}'" > > >> >> > + > > >> >> > +do_install() { > > >> >> > + install -d ${D}${sbindir} > > >> >> > + install -m 0755 ${S}/gatord ${D}${sbindir}/gatord > > >> >> > +} > > >> >> > -- > > >> >> > 2.25.1 > > >> >> > > > >> >> > > >> >> > > >> >> > > > > > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#91060): https://lists.openembedded.org/g/openembedded-devel/message/91060 Mute This Topic: https://lists.openembedded.org/mt/82331135/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
