On Thu, Dec 16, 2021 at 5:57 PM Jeremy Kerr <[email protected]> wrote:
> Hi Khem,
>
> > > +FILES:${PN} += " \
> > > + ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', \
> > > + '${datadir}/dbus-1/system.d/mctpd.conf', '', d)} \
> > > +"
> > > +
> >
> > this should go below do_install and other functions.
>
> OK, can do! I'll send a v2 shortly.
>
> > You can run ./contrib/oe-stylize.py also to get some help on
> > formatting
>
> Hm, that seems to make a bit of a mess of the recipe - it moves a bunch
> of variable declarations to within the do_install:append() block.
>
> I'm no expert on the full syntax, but something like this might fix it:
>
> diff --git a/contrib/oe-stylize.py b/contrib/oe-stylize.py
> index e1ba1b321..eac096a80 100755
> --- a/contrib/oe-stylize.py
> +++ b/contrib/oe-stylize.py
> @@ -211,7 +211,7 @@ OE_vars = [
> ]
>
> varRegexp = r'^([a-zA-Z_0-9${}-]*)([ \t]*)([+.:]?=[+.]?)([ \t]*)([^\t]+)'
> -routineRegexp = r'^([a-zA-Z0-9_ ${}-]+?)\('
> +routineRegexp = r'^([a-zA-Z0-9_ ${}:-]+?)\('
>
> # Variables seen in the processed .bb
> seen_vars = {}
>
>
> - I can send that as a proper patch if that's the correct approach.
>
This seems fine we have new override operator and stylize script needs
adjusting
> Cheers,
>
>
> Jeremy
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#94416):
https://lists.openembedded.org/g/openembedded-devel/message/94416
Mute This Topic: https://lists.openembedded.org/mt/87763264/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
