On Fri, Mar 4, 2022 at 7:27 AM Justin Bronder <[email protected]> wrote:
>
> On 04/03/22 00:04 -0800, Khem Raj wrote:
> > On Thu, Mar 3, 2022 at 10:53 AM Justin Bronder <[email protected]> 
> > wrote:
> > >
> > > Ah right, this package only support arm or x86.  I'll send an update.
> >
> > actually thats not the case, it tries to use SSE when target is x86
> > and crc extensions on aarch64, for
> > other architectures it uses general purpose instructions.
> > however it uses wrong way to detect platform by poking at build system
> > for platform architecture
> > I have sent a patch to fix it.
>
> You're much quicker then I am.  However, based on
> https://github.com/ICRAR/crc32c/pull/10 I think we can simply update 
> setup.cfg.
> I'll send a patch in case you prefer that mechanism, but no problem if 
> patching
> setup.py is preferable.

That patch seems incomplete, it does not consider the arm/aarch64
piece which perhaps
is added after that pull was created. So someone needs to forward port
that patch and
refresh the pull, until then my proposed patch is more comprehensive.

>
> I did try passing '--platform=${TARGET_ARCH}' but bdist_wheel didn't recognize
> the parameter.
>
> >
> > >
> > > On 02/03/22 18:47 -0800, Khem Raj wrote:
> > > > I am seeing a failure with clang on non x86 host. See
> > > >
> > > > https://errors.yoctoproject.org/Errors/Details/650724/
> > > >
> > > > On Mon, Feb 28, 2022 at 7:57 AM Justin Bronder 
> > > > <[email protected]> wrote:
> > > > >
> > > > > Signed-off-by: Justin Bronder <[email protected]>
> > > > > ---
> > > > >  meta-python/licenses/CRC32C-ADLER                | 15 +++++++++++++++
> > > > >  .../python/python3-crc32c_2.2.post0.bb           | 16 
> > > > > ++++++++++++++++
> > > > >  2 files changed, 31 insertions(+)
> > > > >  create mode 100644 meta-python/licenses/CRC32C-ADLER
> > > > >  create mode 100644 
> > > > > meta-python/recipes-devtools/python/python3-crc32c_2.2.post0.bb
> > > > >
> > > > > diff --git a/meta-python/licenses/CRC32C-ADLER 
> > > > > b/meta-python/licenses/CRC32C-ADLER
> > > > > new file mode 100644
> > > > > index 0000000000..f1f0e94ee0
> > > > > --- /dev/null
> > > > > +++ b/meta-python/licenses/CRC32C-ADLER
> > > > > @@ -0,0 +1,15 @@
> > > > > +This software is provided 'as-is', without any express or implied
> > > > > +warranty.  In no event will the author be held liable for any damages
> > > > > +arising from the use of this software.
> > > > > +
> > > > > +Permission is granted to anyone to use this software for any purpose,
> > > > > +including commercial applications, and to alter it and redistribute 
> > > > > it
> > > > > +freely, subject to the following restrictions:
> > > > > +
> > > > > +1. The origin of this software must not be misrepresented; you must 
> > > > > not
> > > > > +   claim that you wrote the original software. If you use this 
> > > > > software
> > > > > +   in a product, an acknowledgment in the product documentation 
> > > > > would be
> > > > > +   appreciated but is not required.
> > > > > +2. Altered source versions must be plainly marked as such, and must 
> > > > > not be
> > > > > +   misrepresented as being the original software.
> > > > > +3. This notice may not be removed or altered from any source 
> > > > > distribution.
> > > > > diff --git 
> > > > > a/meta-python/recipes-devtools/python/python3-crc32c_2.2.post0.bb 
> > > > > b/meta-python/recipes-devtools/python/python3-crc32c_2.2.post0.bb
> > > > > new file mode 100644
> > > > > index 0000000000..0d51420939
> > > > > --- /dev/null
> > > > > +++ b/meta-python/recipes-devtools/python/python3-crc32c_2.2.post0.bb
> > > > > @@ -0,0 +1,16 @@
> > > > > +SUMMARY = "A python package implementing the crc32c algorithmin 
> > > > > hardware and software"
> > > > > +HOMEPAGE = "https://github.com/ICRAR/crc32c";
> > > > > +
> > > > > +LICENSE = "BSD-2-Clause & BSD-3-Clause & CRC32C-ADLER & LGPL-2.0+"
> > > > > +LIC_FILES_CHKSUM = " \
> > > > > +    file://LICENSE;md5=4fbd65380cdd255951079008b364516c \
> > > > > +    
> > > > > file://LICENSE.google-crc32c;md5=e9ed01b5e5ac9eae23fc2bb33701220c \
> > > > > +    file://LICENSE.slice-by-8;md5=6b3bc7709d6b2db6646ec2467310ff6b \
> > > > > +    
> > > > > file://crc32c_adler.c;startline=9;endline=24;md5=c60e6e55d0e5d95effa6fad27db0711a
> > > > >  \
> > > > > +"
> > > > > +
> > > > > +SRC_URI[sha256sum] = 
> > > > > "3d058e7a5e37e4985d1a7ad4cb702bca56b490daa658d4851377d13ead8b435e"
> > > > > +
> > > > > +inherit pypi setuptools3
> > > > > +
> > > > > +RDEPENDS:${PN} += "python3-core"
> > > > > --
> > > > > 2.35.1
> > > > >
> > > > >
> > > > > 
> > > > >
> > >
> > > --
> > > Justin Bronder
>
> --
> Justin Bronder
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#95789): 
https://lists.openembedded.org/g/openembedded-devel/message/95789
Mute This Topic: https://lists.openembedded.org/mt/89532221/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to