On 7 Jun 2023, at 12:41, Böszörményi Zoltán <zbos...@gmail.com> wrote:
>
> 2023. 06. 07. 13:26 keltezéssel, Ross Burton írta:
>> On 7 Jun 2023, at 12:24, Böszörményi Zoltán <zbos...@gmail.com> wrote:
>>>>> +# This prevents the meson error:
>>>>> +# ERROR: Got argument buildtype as both -Dbuildtype and --buildtype.
>>>>> Pick one.
>>>>> +MESONOPTS:remove = "--buildtype ${MESON_BUILDTYPE}"
>>>> If mesonpy ever switches to —buildtype then this will break, right? Might
>>>> be better to patch mesonpy instead.
>>> Why would it break? It does not affect what meson-python is adding
>>> internally.
>>>
>>> This only removes the setting imposed by meson.bbclass
>>> and only needs to change if meson.bbclass switches to -Dbuildtype.
>> My understanding is that meson.bbclass is passing —buildtype and then
>> mesonpy is passing -Dbuildtype.
>
> Correct.
>
>> This :remove removes any —buildtype option, so if mesonpy changes to using
>> —buildtype instead of -Dbuildtype then _both_ buildtype options will be
>> removed, which isn’t what you want.
>
> Wrong.
>
> This only removes the --buildtype setting from MESONOPTS set by meson.bbclass.
Okay, I take it back, thanks.
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#103178):
https://lists.openembedded.org/g/openembedded-devel/message/103178
Mute This Topic: https://lists.openembedded.org/mt/99379800/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
