On Tue, Jun 20, 2023 at 12:58 PM Alex Kiernan <[email protected]> wrote:
>
> On Tue, Jun 20, 2023 at 10:55 AM Beniamin Sandu <[email protected]> 
> wrote:
> >
> > There is one on master-next, it is currently going through the CI runs
> > (I think): 
> > https://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=9cb5f5c6e91612674eb02f79437abbd51ad7b38f.
> > I have tested this one on my side with a couple of different machines
> > on both poky with glibc and yoe with musl, seems fine so far. Mbedtls
> > v2 will still be available, so the end user can build with that if
> > preferred.
> >
> > On a different note, seems the oe patches got added to a PR on github
> > for mdns: https://github.com/apple-oss-distributions/mDNSResponder/pull/2,
> > and someone accepted this last week. Not sure if it's going to do
> > anything, but maybe there is some hope of having them in a future
> > release, even if it's very opaque by nature.
> >
>
> I suspect that's just a lack of process embedded in the repo, so
> anyone can review/approve...
>
I tend to agree, seems there is no real process on GH at the moment.

I think we are fine right now, both versions are still available and
one can choose between them when building, if the version turns out to
be a requirement.
Some issues might arise with other packages in the future if we drop
v2 completely, but I guess we deal with them as they come, as it's
hard to predict every impact that this could have.

> > On Tue, Jun 20, 2023 at 12:46 PM Alex Kiernan <[email protected]> 
> > wrote:
> > >
> > > On Tue, Jun 20, 2023 at 1:51 AM Khem Raj <[email protected]> wrote:
> > > >
> > > > On Mon, Jun 19, 2023 at 12:14 PM Alex Kiernan <[email protected]> 
> > > > wrote:
> > > > >
> > > > > Keeping up with Apple given they take nothing is frankly a right 
> > > > > pain, adding things which are nice to have rather than just broken 
> > > > > seems like we're just adding to the problem. Last time I 
> > > > > resynchronized this it took me days, unless there's a really good 
> > > > > reason to do this, or there's a way to get it upstreamed I'd rather 
> > > > > we didn't.
> > > > >
> > > >
> > > > a different question would be, does upstream mdns stick to mbedTLS 2.x
> > > > or is there support for mbedTLS 3.x expected/supported.
> > > >
> > >
> > > It's completely closed development, so (personally) I've no idea. The
> > > release of code drops generally seems to follow a MacOS release, which
> > > would suggest there's likely to be one fairly soon once 13.5 ships, so
> > > we might have more of an idea in the next few weeks.
> > >
> > > On mbedTLS 3, I don't obviously see that we have a recipe anywhere?
> > >
> > > > >
> > > > > On Mon, 19 Jun 2023, 19:20 Beniamin Sandu, <[email protected]> 
> > > > > wrote:
> > > > >>
> > > > >> Signed-off-by: Beniamin Sandu <[email protected]>
> > > > >> ---
> > > > >>  .../mdns/0009-remove-unneeded-headers.patch   | 33 
> > > > >> +++++++++++++++++++
> > > > >>  .../recipes-protocols/mdns/mdns_1790.80.10.bb |  1 +
> > > > >>  2 files changed, 34 insertions(+)
> > > > >>  create mode 100644 
> > > > >> meta-networking/recipes-protocols/mdns/mdns/0009-remove-unneeded-headers.patch
> > > > >>
> > > > >> diff --git 
> > > > >> a/meta-networking/recipes-protocols/mdns/mdns/0009-remove-unneeded-headers.patch
> > > > >>  
> > > > >> b/meta-networking/recipes-protocols/mdns/mdns/0009-remove-unneeded-headers.patch
> > > > >> new file mode 100644
> > > > >> index 000000000..74d387368
> > > > >> --- /dev/null
> > > > >> +++ 
> > > > >> b/meta-networking/recipes-protocols/mdns/mdns/0009-remove-unneeded-headers.patch
> > > > >> @@ -0,0 +1,33 @@
> > > > >> +From 1d7e71e72c597ffcc19c04373a477d1fbd3ad955 Mon Sep 17 00:00:00 
> > > > >> 2001
> > > > >> +From: Beniamin Sandu <[email protected]>
> > > > >> +Date: Thu, 15 Jun 2023 17:02:58 +0000
> > > > >> +Subject: [PATCH] remove unneeded headers
> > > > >> +
> > > > >> +From a quick look, these seem to not be needed and having them
> > > > >> +breaks the build with mbedtls 3.x. Without them it builds fine
> > > > >> +on both 2.x and 3.x versions.
> > > > >> +
> > > > >> +Upstream-Status: Pending
> > > > >> +
> > > > >> +Signed-off-by: Beniamin Sandu <[email protected]>
> > > > >> +---
> > > > >> + mDNSPosix/mbedtls.c | 2 --
> > > > >> + 1 file changed, 2 deletions(-)
> > > > >> +
> > > > >> +diff --git a/mDNSPosix/mbedtls.c b/mDNSPosix/mbedtls.c
> > > > >> +index a73681b..ab8f8c7 100644
> > > > >> +--- a/mDNSPosix/mbedtls.c
> > > > >> ++++ b/mDNSPosix/mbedtls.c
> > > > >> +@@ -38,10 +38,8 @@
> > > > >> + #include <mbedtls/sha256.h>
> > > > >> + #include <mbedtls/base64.h>
> > > > >> +
> > > > >> +-#include <mbedtls/certs.h>
> > > > >> + #include <mbedtls/x509.h>
> > > > >> + #include <mbedtls/ssl.h>
> > > > >> +-#include <mbedtls/config.h>
> > > > >> +
> > > > >> + // Posix TLS server context
> > > > >> + struct TLSContext_struct {
> > > > >> +--
> > > > >> +2.34.1
> > > > >> diff --git 
> > > > >> a/meta-networking/recipes-protocols/mdns/mdns_1790.80.10.bb 
> > > > >> b/meta-networking/recipes-protocols/mdns/mdns_1790.80.10.bb
> > > > >> index 612d343c8..46f1b70cb 100644
> > > > >> --- a/meta-networking/recipes-protocols/mdns/mdns_1790.80.10.bb
> > > > >> +++ b/meta-networking/recipes-protocols/mdns/mdns_1790.80.10.bb
> > > > >> @@ -21,6 +21,7 @@ SRC_URI = 
> > > > >> "git://github.com/apple-oss-distributions/mDNSResponder;protocol=https
> > > > >>             file://0006-Handle-noisy-netlink-sockets.patch \
> > > > >>             
> > > > >> file://0007-Mark-deleted-interfaces-as-being-changed.patch \
> > > > >>             file://0008-Handle-errors-from-socket-calls.patch \
> > > > >> +           file://0009-remove-unneeded-headers.patch \
> > > > >>             file://mdns.service \
> > > > >>             "
> > > > >>  SRCREV = "8769ab51605e465425d33d757f602ce5905ca639"
> > > > >> --
> > > > >> 2.25.1
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >
> > > > > 
> > > > >
> > >
> > >
> > >
> > > --
> > > Alex Kiernan
>
>
>
> --
> Alex Kiernan
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#103453): 
https://lists.openembedded.org/g/openembedded-devel/message/103453
Mute This Topic: https://lists.openembedded.org/mt/99629056/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to