Hi,

On Wed, 27 Sept 2023 at 22:47, Khem Raj <[email protected]> wrote:
>
> On Wed, Sep 27, 2023 at 12:49 PM Clément Péron <[email protected]> wrote:
> >
> > On Wed, 27 Sept 2023 at 21:48, Clément Péron via
> > lists.openembedded.org <[email protected]>
> > wrote:
> > >
> > > Hi Samuli,
> > >
> > > On Wed, 27 Sept 2023 at 07:20, Samuli Piippo <[email protected]> 
> > > wrote:
> > > >
> > > > Re-applying this patch as it got removed in 
> > > > https://patchwork.yoctoproject.org/project/oe/patch/[email protected]/
> > > >
> > > > On Wed, 27 Sept 2023 at 08:11, Samuli Piippo via lists.openembedded.org 
> > > > <[email protected]> wrote:
> > > >>
> > > >> From: Samuli Piippo <[email protected]>
> > > >>
> > > >> If protoc is enabled for the build, recipes using protobuf will
> > > >> fail when protoc is not available in the recipe sysroot:
> > > >>
> > > >> |   The imported target "protobuf::protoc" references the file
> > > >> |
> > > >> |      
> > > >> ".../recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/bin/protoc-3.21.5.0"
> > > >> |
> > > >> |   but this file does not exist.  Possible reasons include:
> > > >> |
> > > >> |   * The file was deleted, renamed, or moved to another location.
> > > >> |
> > > >> |   * An install or uninstall procedure did not complete successfully.
> > > >> |
> > > >> |   * The installation package was faulty and contained
> > > >> |
> > > >> |      
> > > >> ".../recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake"
> > > >> |
> > > >> |   but not all the files it references.
> > > >>
> > > >> Use SYSROOT_DIRS to stage the binary to sysroot so it's always
> > > >> available for other recipes.
> > >
> > > +Ross Burton
> > >
> > > You will have the same issue with gRPC binaries and I think the best 
> > > solution
> > > is to fix the QT CMake instead of contaminating the rootfs, no?
> > >
> > > You should update to have something like this:
> > > https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/blob/master/CMakeLists.txt
> >
> > This patch in particular
> > https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/commit/47f0d9e0326f3cc31c801a0ecf7312d1049ece3e
>
> yeah, this to me looks a better fix since its scoped at recipe level
> and makes is cross compile friendly.
> I hope it will keep working with older versions of protobuffers

Also I don't see the recipe "qtgrpc" in meta-oe nor other layers.

https://layers.openembedded.org/layerindex/branch/master/recipes/?q=qtgrpc

I would be in favor of reverting this patch if there is no answer from Samuli.

Samuli, could you point to a bitbake recipe to build qtgrpc ?

Regards,

>
> >
> >
> > >
> > > Regards,
> > > Clement
> > >
> > >
> > > >>
> > > >> Signed-off-by: Samuli Piippo <[email protected]>
> > > >> Signed-off-by: Khem Raj <[email protected]>
> > > >> ---
> > > >>  meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb | 3 +++
> > > >>  1 file changed, 3 insertions(+)
> > > >>
> > > >> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb 
> > > >> b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb
> > > >> index d95e1c20f..06b21a0d6 100644
> > > >> --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb
> > > >> +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb
> > > >> @@ -92,6 +92,9 @@ PACKAGE_BEFORE_PN = "${PN}-compiler ${PN}-lite"
> > > >>  FILES:${PN}-compiler = "${bindir} ${libdir}/libprotoc${SOLIBS}"
> > > >>  FILES:${PN}-lite = "${libdir}/libprotobuf-lite${SOLIBS}"
> > > >>
> > > >> +# CMake requires binaries to exist in sysroot, even if they have 
> > > >> wrong architecture.
> > > >> +SYSROOT_DIRS += "${bindir}"
> > > >> +
> > > >>  RDEPENDS:${PN}-compiler = "${PN}"
> > > >>  RDEPENDS:${PN}-dev += "${PN}-compiler"
> > > >>  RDEPENDS:${PN}-ptest = "bash ${@bb.utils.contains('PACKAGECONFIG', 
> > > >> 'python', 'python3-protobuf', '', d)}"
> > > >> --
> > > >> 2.25.1
> > > >>
> > > >>
> > > >>
> > > >>
> > > >
> > > >
> > > >
> > >
> > > 
> > >
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105221): 
https://lists.openembedded.org/g/openembedded-devel/message/105221
Mute This Topic: https://lists.openembedded.org/mt/101612304/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to