On Sat, Nov 18, 2023 at 10:27 AM Jan Claußen <[email protected]> wrote:

> No idea if I did that right now. I really don't understand why you guys
> use the email based merge requests, but well.
>

I can talk about it over a beer :)
Thanks for treading along.

>
> On Nov. 18 2023, at 5:45 pm, Khem Raj <[email protected]> wrote:
>
> thats fine and thanks for update. However, if you can resend it via
> git format-patch && git send-email then tools I use will capture the
> v2 properly.
>
> On Sat, Nov 18, 2023 at 5:51 AM Jan Claußen <[email protected]> wrote:
> >
> > So in this case it shoule be alright like this. The developer will have
> to take care to set its proper locale, but apart from that everything works.
> >
> > From b242979231f4f32243b99cb8312fe4de07b0d87b Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Jan=20Clau=C3=9Fen?= <[email protected]>
> > Date: Sat, 18 Nov 2023 14:45:27 +0100
> > Subject: [PATCH] meta-oe: recipes-support: Add btop
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > Adds btop, the shell-based resource monitor that shows usage and stats
> for processor, memory, disks, network and processes.
> >
> > Signed-off-by: Jan Claußen <[email protected]>
> > ---
> > meta-oe/recipes-support/btop/btop_1.2.13.bb | 23 +++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> > create mode 100644 meta-oe/recipes-support/btop/btop_1.2.13.bb
> >
> > diff --git a/meta-oe/recipes-support/btop/btop_1.2.13.bb
> b/meta-oe/recipes-support/btop/btop_1.2.13.bb
> > new file mode 100644
> > index 000000000..a944fe7b5
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/btop/btop_1.2.13.bb
> > @@ -0,0 +1,23 @@
> > +SUMMARY = "Resource monitor that shows usage and stats for processor,
> memory, disks, network and processes."
> > +HOMEPAGE = "https://github.com/aristocratos/btop";
> > +LICENSE = "Apache-2.0"
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> > +SECTION = "console/utils"
> > +
> > +SRC_URI = "git://
> github.com/aristocratos/btop.git;protocol=https;branch=main"
> > +SRCREV = "9edbf27f1b6d5844a97325fcda732762ba086a99"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +inherit cmake
> > +
> > +FILES:${PN} += " \
> > + ${datadir}/icons \
> > + ${datadir}/icons/hicolor \
> > + ${datadir}/icons/hicolor/48x48 \
> > + ${datadir}/icons/hicolor/scalable \
> > + ${datadir}/icons/hicolor/48x48/apps \
> > + ${datadir}/icons/hicolor/48x48/apps/btop.png \
> > + ${datadir}/icons/hicolor/scalable/apps \
> > + ${datadir}/icons/hicolor/scalable/apps/btop.svg \
> > +"
> > --
> > 2.42.1
> >
> > On Nov. 14 2023, at 9:43 pm, Khem Raj <[email protected]> wrote:
> >
> > On Tue, Nov 14, 2023 at 12:38 PM Jan Claußen <[email protected]>
> wrote:
> > >
> > > So I have just tested btop on musl succesfully.
> > >
> >
> > OK
> >
> > > I am questioning the need for the locales though. You can run btop
> with the --utf-force flag and it will work well. If you want to run it
> without this flag, you'll need to not only install the locales, but also add
> > >
> > > LC_ALL=en_US.UTF-8
> > > LANG=en_US.UTF-8
> > >
> >
> > yeah if it can work without it, that would be great
> >
> > > to /etc/profile as a minimum. This would force the user to use these
> locales. It would also require a .bbappend on base-files and I don't think
> that this is a good idea.
> > >
> > > On Nov. 12 2023, at 9:24 pm, Jan Claußen <[email protected]>
> wrote:
> > >
> > > How did you build it? I have sent you a PM on IRC
> > >
> > > On Nov. 12 2023, at 9:21 pm, Khem Raj <[email protected]> wrote:
> > >
> > > On Sun, Nov 12, 2023 at 10:51 AM Jan Claußen <[email protected]>
> wrote:
> > > >
> > > > No, it is an issue I have with images for the Pi Zero. I haven't
> build anything for musl at all, although it would probably a good choice
> for the Pi Zero.
> > > >
> > > > I have no issues using Raspberry Pi OS or other distros btw, so the
> device is not the issue
> > >
> > > As one point I have pi0 running fine perhaps something has regressed
> > > in meta-raspberrypi :( these things need TLC to keep going.
> > >
> > > > On Nov. 12 2023, at 7:49 pm, Khem Raj <[email protected]> wrote:
> > > >
> > > > hmm is that just seen with musl and works ok with glibc based images
> ?
> > > >
> > > > TCLIBC=musl bitbake core-image-base
> > > >
> > > > eg. will produce a musl based image which is expected to work
> > > >
> > > > On Sun, Nov 12, 2023 at 10:23 AM Jan Claußen <[email protected]>
> wrote:
> > > > >
> > > > > Unfortunately I can't test it unless this gets solved (or I buy a
> different Raspberry Pi)
> > > > >
> > > > > https://github.com/agherzan/meta-raspberrypi/issues/1229
> > > > >
> > > > > On Nov. 12 2023, at 6:43 pm, Khem Raj <[email protected]> wrote:
> > > > >
> > > > > TCLIBC=musl bitbake <recipe>
> > > > >
> > > > > On Sun, Nov 12, 2023 at 9:24 AM Jan Claußen <[email protected]>
> wrote:
> > > > > >
> > > > > > How to test it against musl btw? Build a musl-based system for
> Raspberry Pi and see if it runs?
> > > > > >
> > > > > > On Nov. 12 2023, at 6:23 pm, Jan Claußen <[email protected]>
> wrote:
> > > > > >
> > > > > > Yes, the CMake support was added two months ago and the release
> is from 2022. Cmake is also not supported by the main developer who seems
> to favor an advanced Makefile. In any case, it is easier to fix than the
> Makefile. I will go with the git version for now then until there is a new
> release.
> > > > > >
> > > > > > On Nov. 12 2023, at 6:20 pm, Khem Raj <[email protected]>
> wrote:
> > > > > >
> > > > > > On Sun, Nov 12, 2023 at 8:25 AM Jan Claußen <
> [email protected]> wrote:
> > > > > > >
> > > > > > > I am trying with the tarball but it is quite hard, since it
> doesn't come with a CMakeLists.txt.
> > > > > > > There is a recipe here, but it involves a lot of patching
> which could potentially be painful to maintain
> > > > > > >
> > > > > > >
> https://github.com/aristocratos/btop/issues/330#issuecomment-1123685779
> > > > > > >
> > > > > >
> > > > > > is it because cmake support was added later ? in that case maybe
> using
> > > > > > git version is ok
> > > > > >
> > > > > > > On Nov. 11 2023, at 8:01 pm, Khem Raj <[email protected]>
> wrote:
> > > > > > >
> > > > > > > On Sat, Nov 11, 2023 at 10:38 AM Jan Claußen <
> [email protected]> wrote:
> > > > > > > >
> > > > > > > > It also needs a utf-8 locale to work. Else you have to force
> utf-8 mode with a flag. I haven't included this as dependency at this point.
> > > > > > >
> > > > > > > you want to express all that is needed to get it running
> amicably.
> > > > > > > keeping in mind that we have glibc and musl based systems to
> service
> > > > > > > it will be good to check it on musl too.
> > > > > > >
> > > > > > > >
> > > > > > > > On Nov. 11 2023, at 7:35 pm, Jan Claußen <
> [email protected]> wrote:
> > > > > > > >
> > > > > > > > Glad that it arrived now! This is a really great resource
> monitor. It is building from the git repository. Do you think it is better
> to use the release instead?
> > > > > > > >
> > > > > > > > On Nov. 11 2023, at 7:30 pm, Khem Raj <[email protected]>
> wrote:
> > > > > > > >
> > > > > > > > Thanks for your contribution Jan
> > > > > > > >
> > > > > > > > On Sat, Nov 11, 2023 at 10:26 AM Jan Claußen <
> [email protected]> wrote:
> > > > > > > > >
> > > > > > > > > ---
> > > > > > > > > meta-oe/recipes-support/btop/btop_1.2.13.bb | 23
> +++++++++++++++++++++
> > > > > > > > > 1 file changed, 23 insertions(+)
> > > > > > > > > create mode 100644 meta-oe/recipes-support/btop/
> btop_1.2.13.bb
> > > > > > > > >
> > > > > > > > > diff --git a/meta-oe/recipes-support/btop/btop_1.2.13.bb
> b/meta-oe/recipes-support/btop/btop_1.2.13.bb
> > > > > > > > > new file mode 100644
> > > > > > > > > index 000000000..f780a993a
> > > > > > > > > --- /dev/null
> > > > > > > > > +++ b/meta-oe/recipes-support/btop/btop_1.2.13.bb
> > > > > > > > > @@ -0,0 +1,23 @@
> > > > > > > > > +SUMMARY = "Resource monitor that shows usage and stats
> for processor, memory, disks, network and processes."
> > > > > > > > > +HOMEPAGE = "https://github.com/aristocratos/btop";
> > > > > > > > > +LICENSE = "Apache-2.0"
> > > > > > > > > +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> > > > > > > > > +SECTION = "console/utils"
> > > > > > > > > +
> > > > > > > > > +SRC_URI = "git://
> github.com/aristocratos/btop.git;protocol=https;branch=main"
> > > > > > > > > +SRCREV = "2a864f6f2ea60df16b3f015885eb3c18a48b9b78"
> > > > > > > > > +
> > > > > > > > > +S = "${WORKDIR}/git"
> > > > > > > > > +
> > > > > > > > > +inherit cmake
> > > > > > > > > +
> > > > > > > > > +FILES:${PN} += " \
> > > > > > > > > + /usr/share/icons \
> > > > > > > >
> > > > > > > > Lets use ${datadir} instead of hardcoded /usr/share
> > > > > > > >
> > > > > > > > > + /usr/share/icons/hicolor \
> > > > > > > > > + /usr/share/icons/hicolor/48x48 \
> > > > > > > > > + /usr/share/icons/hicolor/scalable \
> > > > > > > > > + /usr/share/icons/hicolor/48x48/apps \
> > > > > > > > > + /usr/share/icons/hicolor/48x48/apps/btop.png \
> > > > > > > > > + /usr/share/icons/hicolor/scalable/apps \
> > > > > > > > > + /usr/share/icons/hicolor/scalable/apps/btop.svg \
> > > > > > > > > +"
> > > > > > > > > --
> > > > > > > > > 2.42.0
> > > > > > > > >
> > > > > > > > > 
> > > > > > > > >
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106893): 
https://lists.openembedded.org/g/openembedded-devel/message/106893
Mute This Topic: https://lists.openembedded.org/mt/102530478/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to