> Why is this line deleted? The CVE still doesn’t record versions, so this
> will make the issue reappear in the report.
Deleted accidentally, my fault. I'll be more careful next time.
> Are these no longer needed? Or did they get deleted accidentally? As it
> stands, I can’t tell.
The reason I deleted it is because there is a line in CMakeLists.txt
like "set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib")" and that
sets the runpath. If "foo.so" is not present in the runpath, as far as
I know, every shared library is searched in the following locations:
rpath -> LD_LIBRARY_PATH -> runpath -> ld.so.conf -> /lib and /usr/lib
by default. I don't think there's any point in deleting the runpath.
CMakeLists.txt ->
https://github.com/jasper-software/jasper/blob/917f7708b755d8434f70618108c1a76f1b6a0a82/CMakeLists.txt#L809
> Just because there can be an option doesn't mean we should expose it. We
> should always build a shared library, we should always build PIC code, we
> should already support threads, etc. Docs should be guarded on the
> api-documentation DISTRO_FEATURE. Arguably some of the format support options
> could remain (based on the prior art of JPEG) but notably that means
> dependencies, which is why it was added in the first place. But on the whole
> we don’t want to expose _every_ option in the recipe, just the ones that make
> sense. Remember users of the recipe can easily add their own if they need to
> control the recipe even further.
>
> Whilst I’m looking, if this is a library that ships with some tools then the
> tools should always be built (that would be the programs config, I guess) but
> the recipe should inherit lib_package so that they’re put into a separate
> package and only installed if needed.
I thought the user should know every option. "Docs should be guarded
on the api-documentation DISTRO_FEATURE", I don't understand exactly
what this means. Thank you for feedback.
Best regards
Ross Burton <[email protected]>, 4 Ara 2023 Pzt, 23:21 tarihinde şunu yazdı:
>
> > -do_install:append() {
> > - chrpath -d ${D}${bindir}/jasper
> > - chrpath -d ${D}${bindir}/imginfo
> > - chrpath -d ${D}${bindir}/imgcmp
> > - chrpath -d ${D}${libdir}/libjasper.so.*
> > -}
>
> Are these no longer needed? Or did they get deleted accidentally? As it
> stands, I can’t tell.
>
> > +PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
> > 'opengl', '', d)} \
> > + shared-lib PIC hidden jpeg heif opengl doc latex programs multithread
> > pthread bmp jp2 jpc jpg pgx pnm ras \
> > + "
> > +
> > +PACKAGECONFIG[shared-lib] =
> > "-DJAS_ENABLE_SHARED=ON,-DJAS_ENABLE_SHARED=OFF,,"
> > +PACKAGECONFIG[PIC] = "-DJAS_ENABLE_PIC=ON,-DJAS_ENABLE_PIC=OFF,,"
> > +PACKAGECONFIG[hidden] = "-DJAS_ENABLE_HIDDEN=ON,-DJAS_ENABLE_HIDDEN=OFF,,"
> > +PACKAGECONFIG[32bit] = "-DJAS_ENABLE_32BIT=ON,-DJAS_ENABLE_32BIT=OFF,,"
> > +PACKAGECONFIG[jpeg] =
> > "-DJAS_ENABLE_LIBJPEG=ON,-DJAS_ENABLE_LIBJPEG=OFF,jpeg,"
> > +PACKAGECONFIG[heif] = "-DJAS_ENABLE_LIBHEIF=ON,-DJAS_ENABLE_LIBHEIF=OFF,,"
> > +PACKAGECONFIG[opengl] =
> > "-DJAS_ENABLE_OPENGL=ON,-DJAS_ENABLE_OPENGL=OFF,freeglut,"
> > +PACKAGECONFIG[doc] = "-DJAS_ENABLE_DOC=ON,-DJAS_ENABLE_DOC=OFF,doxygen,"
> > +PACKAGECONFIG[latex] = "-DJAS_ENABLE_LATEX=ON,-DJAS_ENABLE_LATEX=OFF,,"
> > +PACKAGECONFIG[programs] =
> > "-DJAS_ENABLE_PROGRAMS=ON,-DJAS_ENABLE_PROGRAMS=OFF,,"
> > +PACKAGECONFIG[multithread] =
> > "-DJAS_ENABLE_MULTITHREADING_SUPPORT=ON,-DJAS_ENABLE_MULTITHREADING_SUPPORT=OFF,,"
> > +PACKAGECONFIG[pthread] =
> > "-DJAS_PREFER_PTHREAD=ON,-DJAS_PREFER_PTHREAD=OFF,,"
> > +PACKAGECONFIG[pthread-tss] =
> > "-DJAS_PREFER_PTHREAD_TSS=ON,-DJAS_PREFER_PTHREAD_TSS=OFF,,"
> > +PACKAGECONFIG[strict] = "-DJAS_STRICT=ON,-DJAS_STRICT=OFF,,"
> > +PACKAGECONFIG[bmp] =
> > "-DJAS_ENABLE_BMP_CODEC=ON,-DJAS_ENABLE_BMP_CODEC=OFF,,"
> > +PACKAGECONFIG[jp2] =
> > "-DJAS_ENABLE_JP2_CODEC=ON,-DJAS_ENABLE_JP2_CODEC=OFF,,"
> > +PACKAGECONFIG[jpc] =
> > "-DJAS_ENABLE_JPC_CODEC=ON,-DJAS_ENABLE_JPC_CODEC=OFF,,"
> > +PACKAGECONFIG[jpg] =
> > "-DJAS_ENABLE_JPG_CODEC=ON,-DJAS_ENABLE_JPG_CODEC=OFF,,"
> > +PACKAGECONFIG[heic] =
> > "-DJAS_ENABLE_HEIC_CODEC=ON,-DJAS_ENABLE_HEIC_CODEC=OFF,,"
> > +PACKAGECONFIG[mif] =
> > "-DJAS_ENABLE_MIF_CODEC=ON,-DJAS_ENABLE_MIF_CODEC=OFF,,"
> > +PACKAGECONFIG[pgx] =
> > "-DJAS_ENABLE_PGX_CODEC=ON,-DJAS_ENABLE_PGX_CODEC=OFF,,"
> > +PACKAGECONFIG[pnm] =
> > "-DJAS_ENABLE_PNM_CODEC=ON,-DJAS_ENABLE_PNM_CODEC=OFF,,"
> > +PACKAGECONFIG[ras] =
> > "-DJAS_ENABLE_RAS_CODEC=ON,-DJAS_ENABLE_RAS_CODEC=OFF,,”
>
> Just because there can be an option doesn't mean we should expose it. We
> should always build a shared library, we should always build PIC code, we
> should already support threads, etc. Docs should be guarded on the
> api-documentation DISTRO_FEATURE. Arguably some of the format support options
> could remain (based on the prior art of JPEG) but notably that means
> dependencies, which is why it was added in the first place. But on the whole
> we don’t want to expose _every_ option in the recipe, just the ones that make
> sense. Remember users of the recipe can easily add their own if they need to
> control the recipe even further.
>
> Whilst I’m looking, if this is a library that ships with some tools then the
> tools should always be built (that would be the programs config, I guess) but
> the recipe should inherit lib_package so that they’re put into a separate
> package and only installed if needed.
>
> Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#107222):
https://lists.openembedded.org/g/openembedded-devel/message/107222
Mute This Topic: https://lists.openembedded.org/mt/102978026/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
