Sure, I agree with your comments; I'll propose a patch v3 tonight or during the week-end, taking all this into consideration.
On Fri, Mar 15, 2024 at 1:34 AM Marek Vasut <[email protected]> wrote: > On 3/14/24 8:21 PM, Christophe Chapuis wrote: > > As it can be usefull to customize these other variables, let's > > add them in lv-conf.inc. > > > > Also, fix the install path to use ${PN} instead of "lvgl". > > Separate commit would be nice. > > btw when sending V3, please CC Khem and co. if you didn't yet. > > Also, I'll likely be sending LVGL 9.1 update next week, it should be out > then. > > > Signed-off-by: Christophe Chapuis <[email protected]> > > --- > > meta-oe/recipes-graphics/lvgl/lv-conf.inc | 49 +++++++++++++++-------- > > 1 file changed, 33 insertions(+), 16 deletions(-) > > > > diff --git a/meta-oe/recipes-graphics/lvgl/lv-conf.inc > b/meta-oe/recipes-graphics/lvgl/lv-conf.inc > > index cd14412e1..088842490 100644 > > --- a/meta-oe/recipes-graphics/lvgl/lv-conf.inc > > +++ b/meta-oe/recipes-graphics/lvgl/lv-conf.inc > > @@ -12,8 +12,17 @@ LVGL_CONFIG_USE_SDL = > "${@bb.utils.contains('PACKAGECONFIG', 'sdl', '1', '0', d) > > LVGL_CONFIG_SDL_FULLSCREEN ?= "0" > > > > LVGL_CONFIG_LV_MEM_CUSTOM ?= "0" > > +LVGL_CONFIG_LV_MEM_SIZE ?= "(64 * 1024U)" > > LVGL_CONFIG_LV_COLOR_DEPTH ?= "32" > > > > +LVGL_CONFIG_LV_USE_LOG ?= "0" > > +LVGL_CONFIG_LV_LOG_LEVEL ?= "LV_LOG_LEVEL_WARN" > > +LVGL_CONFIG_LV_LOG_PRINTF ?= "0" > > + > > +LVGL_CONFIG_LV_USE_FONT_COMPRESSED ?= "0" > > + > > +LVGL_CONFIG_LV_THEME_DEFAULT_DARK ?= "0" > > + > > DEBUG_BUILD ??= "0" > > > > ALLOW_EMPTY:${PN} = "1" > > @@ -26,34 +35,42 @@ do_configure:append() { > > > > sed -e "s|#if 0 .*Set it to \"1\" to enable content.*|#if 1 // > Enabled by ${PN}|g" \ > > \ > > - -e "s|\(^#define LV_USE_LINUX_DRM \).*|#define LV_USE_LINUX_DRM > ${LVGL_CONFIG_USE_DRM}|g" \ > > + -e "s|\(^#define LV_USE_LINUX_DRM > \).*|\1${LVGL_CONFIG_USE_DRM}|g" \ > > I'd say, make this clean up a separate patch, otherwise this is > difficult to review. > > Then, add the extra features on top. > > Thanks ! >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#109335): https://lists.openembedded.org/g/openembedded-devel/message/109335 Mute This Topic: https://lists.openembedded.org/mt/104933491/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
