The extra -I flag won't harm even when libdrm isn't there. lvgl-demo-fb also doesn't do it conditionally based on drm PACKAGECONFIG.
If someone want's to fix this properly then should also use pkg-config (and tests/FindLibDRM.cmake in the lvgl repo), but lets not block this fix based on that. This whole issue is just revealed by the typo fix in https://patchwork.yoctoproject.org/project/oe/patch/20240316100056.409758-1-chris.chap...@gmail.com/ which fixed lv-conf.inc to work for lvgl resulting in LV_USE_LINUX_DRM being respected based on PACKAGECONFIG drm. Acked-by: Martin Jansa <martin.ja...@gmail.com> On Sun, Mar 17, 2024 at 6:45 AM Marek Vasut <ma...@denx.de> wrote: > > On 3/16/24 10:55 PM, Christophe Chapuis wrote: > > It could be conditional eventually; I just took the line from lvgl-demo-fb, > > where it wasn't. > > > > Ideally, both should be moved in lv-conf.inc, where the lvgl drm setting is > > activated. But I didn't want to expand again the scope of this patchset, > > initially focused simply on adding some variables to lv-conf.inc. > > I think I will just defer that decision to Khem. > > My concern is that a system with SDL or fbdev backend may not have > libdrm available, so I think it should be conditional. > > I think this will handle that concern: > > TARGET_CFLAGS += "${@bb.utils.contains('PACKAGECONFIG', 'drm', > '-I${STAGING_INCDIR}/libdrm', '', d)}" > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#109377): https://lists.openembedded.org/g/openembedded-devel/message/109377 Mute This Topic: https://lists.openembedded.org/mt/104964303/21656 Group Owner: openembedded-devel+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
