On Thu, Jun 6, 2024 at 9:23 AM Kai Kang via lists.openembedded.org
<[email protected]> wrote:
>
> From: Kai Kang <[email protected]>
>
> Fix incompatible pointer type error for daq:
>
> | ../../daq-2.0.7/os-daq-modules/daq_nfq.c: In function 'SetPktHdr':
> | ../../daq-2.0.7/os-daq-modules/daq_nfq.c:394:37: error: passing argument 2 
> of 'nfq_get_payload' from incompatible pointer type 
> [-Wincompatible-pointer-types]
> |   394 |     int len = nfq_get_payload(nfad, (char**)pkt);
> |       |                                     ^~~~~~~~~~~
> |       |                                     |
> |       |                                     char **
>
> Signed-off-by: Kai Kang <[email protected]>
> ---
>  .../recipes-connectivity/daq/daq_2.0.7.bb     |  1 +
>  ...-fix-incompatible-pointer-type-error.patch | 30 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
>  create mode 100644 
> meta-networking/recipes-connectivity/daq/files/daq-fix-incompatible-pointer-type-error.patch
>
> diff --git a/meta-networking/recipes-connectivity/daq/daq_2.0.7.bb 
> b/meta-networking/recipes-connectivity/daq/daq_2.0.7.bb
> index 66ad83f71..8cb4c04fa 100644
> --- a/meta-networking/recipes-connectivity/daq/daq_2.0.7.bb
> +++ b/meta-networking/recipes-connectivity/daq/daq_2.0.7.bb
> @@ -11,6 +11,7 @@ DEPENDS = "libpcap libpcre libdnet bison-native 
> libnetfilter-queue"
>  SRC_URI = "http://fossies.org/linux/misc/daq-${PV}.tar.gz \
>             file://disable-run-test-program-while-cross-compiling.patch \
>             file://0001-correct-the-location-of-unistd.h.patch \
> +           file://daq-fix-incompatible-pointer-type-error.patch \
>             "
>  SRC_URI[sha256sum] = 
> "bdc4e5a24d1ea492c39ee213a63c55466a2e8114b6a9abed609927ae13a7705e"
>  # these 2 create undeclared dependency on libdnet and libnetfilter-queue 
> from meta-networking
> diff --git 
> a/meta-networking/recipes-connectivity/daq/files/daq-fix-incompatible-pointer-type-error.patch
>  
> b/meta-networking/recipes-connectivity/daq/files/daq-fix-incompatible-pointer-type-error.patch
> new file mode 100644
> index 000000000..5a02d1615
> --- /dev/null
> +++ 
> b/meta-networking/recipes-connectivity/daq/files/daq-fix-incompatible-pointer-type-error.patch
> @@ -0,0 +1,30 @@
> +Fix daq incompatible pointer type error:
> +
> +| ../../daq-2.0.7/os-daq-modules/daq_nfq.c: In function 'SetPktHdr':
> +| ../../daq-2.0.7/os-daq-modules/daq_nfq.c:394:37: error: passing argument 2 
> of 'nfq_get_payload' from incompatible pointer type 
> [-Wincompatible-pointer-types]
> +|   394 |     int len = nfq_get_payload(nfad, (char**)pkt);
> +|       |                                     ^~~~~~~~~~~
> +|       |                                     |
> +|       |                                     char **
> +
> +Upstream-Status: Pending
> +

please submit upstream as well

> +Signed-off-by: Kai Kang <[email protected]>
> +
> +---
> + os-daq-modules/daq_nfq.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/os-daq-modules/daq_nfq.c b/os-daq-modules/daq_nfq.c
> +index 4de94b6..a6de2f3 100644
> +--- a/os-daq-modules/daq_nfq.c
> ++++ b/os-daq-modules/daq_nfq.c
> +@@ -391,7 +391,7 @@ static inline int SetPktHdr (
> +     DAQ_PktHdr_t* hdr,
> +     uint8_t** pkt
> + ) {
> +-    int len = nfq_get_payload(nfad, (char**)pkt);
> ++    int len = nfq_get_payload(nfad, (unsigned char**)pkt);
> +
> +     if ( len <= 0 )
> +         return -1;
> --
> 2.34.1
>
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#110754): 
https://lists.openembedded.org/g/openembedded-devel/message/110754
Mute This Topic: https://lists.openembedded.org/mt/106526692/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to