On Mon, 2 Sept 2024 at 13:13, Yoann Congal <[email protected]> wrote: > > Hi, > > Le 02/09/2024 à 11:34, Dmitry Baryshkov via lists.openembedded.org a écrit : > > Sending patches via GH results in the reviews of a lesser quality. > > Discourage its usage and point out that developers should use emails > > only. > > > > Signed-off-by: Dmitry Baryshkov <[email protected]> > > --- > > meta-oe/README.md | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/meta-oe/README.md b/meta-oe/README.md > > index 676a2c89252a..0e9d43c10f91 100644 > > --- a/meta-oe/README.md > > +++ b/meta-oe/README.md > > @@ -24,6 +24,10 @@ When sending single patches, please use something like: > > You are encouraged to fork the mirror on GitHub > > https://github.com/openembedded/meta-openembedded > > to share your patches, this is preferred for patch sets consisting of more > > than one patch. > > > > +Note, it is discouraged to send patches via GitHub pull request system. > > Such > > +patches get less attention from developers and can be mishandled or not > > +reviewed properly. Please use emails instead. > > + > > Doesn't that contradict the paragraph just above? For context, it says: > > You are encouraged to fork the mirror on GitHub > > https://github.com/openembedded/meta-openembedded > > to share your patches, this is preferred for patch sets consisting of more > > than one patch. > > For example, I actually felt encouraged to use the Github PR system for some > contributions (with more than one patch). But maybe that was wrong... :/
And the next paragraph mentions GitLab and repo.or.cz. After several discussions on GH I think that it was meant as 'use these services to push you patches and then send a pull request by email using git request-pull'. > > Regards, > > > > Other services like GitLab, repo.or.cz or self-hosted setups are of course > > accepted as well, > > 'git fetch <remote>' works the same on all of them. We recommend GitHub > > because it is free, easy > > to use, has been proven to be reliable and has a really good web GUI. > > > > > > > > > > > > -- > Yoann Congal > Smile ECS - Tech Expert -- With best wishes Dmitry
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#112071): https://lists.openembedded.org/g/openembedded-devel/message/112071 Mute This Topic: https://lists.openembedded.org/mt/108223947/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
