Hello Khem,

On Tue, 2024-11-05 at 13:06 -0800, Khem Raj wrote:
> it seems to fail YP layer compatibility check as well
> 
> https://valkyrie.yoctoproject.org/#/builders/81/builds/134/steps/11/logs/errors
> 
> opusfile in from meta-multimedia and meta-oe does not depend upon
> meta-multimedia
> so you can make it a packageconfig and disable it by default, or
> perhaps disable it completely if
> not needed. Other option would be to move it under dynamic layers.
> 

Thank you for your review, I will push a version 2 with the requested
modifications.

Kind regards,
Thomas Perrot

> On Tue, Nov 5, 2024 at 8:19 AM Khem Raj <[email protected]> wrote:
> > 
> > On Mon, Nov 4, 2024 at 11:16 PM Thomas Perrot via
> > lists.openembedded.org
> > <[email protected]> wrote:
> > > 
> > > From: Thomas Perrot <[email protected]>
> > > 
> > > Taisei Project is an open source danmaku.
> > > 
> > > Signed-off-by: Thomas Perrot <[email protected]>
> > > ---
> > >  .../packagegroups/packagegroup-meta-oe.bb     |  1 +
> > >  .../recipes-graphics/taisei/taisei_1.4.2.bb   | 52
> > > +++++++++++++++++++
> > >  2 files changed, 53 insertions(+)
> > >  create mode 100644 meta-oe/recipes-
> > > graphics/taisei/taisei_1.4.2.bb
> > > 
> > > diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-
> > > meta-oe.bb b/meta-oe/recipes-core/packagegroups/packagegroup-
> > > meta-oe.bb
> > > index 178256c83f63..4635fe3d44d0 100644
> > > --- a/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
> > > +++ b/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
> > > @@ -521,6 +521,7 @@ RDEPENDS:packagegroup-meta-oe-graphics = "\
> > >      ${@bb.utils.contains("DISTRO_FEATURES", "x11", "st", "", d)}
> > > \
> > >      stalonetray \
> > >      surf \
> > > +    taisei \
> > >      terminus-font-consolefonts \
> > >      terminus-font-pcf \
> > >      tesseract \
> > > diff --git a/meta-oe/recipes-graphics/taisei/taisei_1.4.2.bb
> > > b/meta-oe/recipes-graphics/taisei/taisei_1.4.2.bb
> > > new file mode 100644
> > > index 000000000000..2d2ab32bace7
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-graphics/taisei/taisei_1.4.2.bb
> > > @@ -0,0 +1,52 @@
> > > +SUMMARY = "Taisei Project is an open source danmaku"
> > > +DESCRIPTION = "Taisei Project is an open source fan-game set in
> > > the world of \
> > > +               Tōhō Project. It is a top-down vertical-scrolling
> > > curtain fire \
> > > +               shooting game (STG), also known as a 'bullet
> > > hell' or 'danmaku'. \
> > > +               STGs are fast-paced games focused around pattern
> > > recognition and \
> > > +               mastery through practice."
> > > +HOMEPAGE = "https://taisei-project.org";
> > > +BUGTRACKER = "https://github.com/taisei-project/taisei/issues";
> > > +LICENSE = "CC-BY-4.0 & CC0-1.0 & MIT"
> > > +LIC_FILES_CHKSUM =
> > > "file://COPYING;md5=1a11ffd7e1bdd1d3156cecec60a2846f"
> > > +
> > > +DEPENDS = "\
> > > +    cglm \
> > > +    freetype \
> > > +    libsdl2 \
> > > +    libwebp \
> > > +    opusfile \
> > > +    zstd \
> > > +"
> > > +
> > > +RDEPENDS_${PN} = "\
> > > +    cglm (>= 0.7.8) \
> > > +    freetype \
> > > +    libsdl2 (>= 2.0.16) \
> > > +    libpng (>= 1.5.0) \
> > > +    libwebp (>= 0.5) \
> > > +    libzstd (>= 1.4.0) \
> > > +    opengl (>= 3.3) \
> > > +    opusfile \
> > > +    zlib \
> > > +"
> > > +
> > > +SRC_URI = "gitsm://github.com/taisei-
> > > project/taisei.git;branch=v1.4.x;protocol=https"
> > > +SRCREV = "c098579d4fa0f004ccc204c5bc46eac3717cba28"
> > > +
> > > +S = "${WORKDIR}/git"
> > > +
> > > +inherit features_check meson mime mime-xdg pkgconfig
> > > python3native
> > > +
> > > +REQUIRED_DISTRO_FEATURES = "opengl"
> > > +
> > > +PACKAGECONFIG ??= ""
> > > +
> > > +PACKAGECONFIG[a_null] = "-Da_null=true,-Da_null=false"
> > > +PACKAGECONFIG[developer] = "-Ddeveloper=true,-Ddeveloper=false"
> > > +PACKAGECONFIG[docs] = "-Ddocs=true,-Ddocs=false,python3-
> > > docutils-native"
> > > +
> > > +
> > > +
> > > +FILES:${PN} += "${prefix}/share"
> > 
> > there is a dedicated variable ${datadir} you can use here
> > 
> > > +
> > > +INSANE_SKIP:${PN} = "already-stripped"
> > 
> > can we patch the makefiles to not strip the binaries and leave it
> > to OE tasks ?
> > This can improve debugging experience.
> > 
> > > --
> > > 2.47.0
> > > 
> > > 
> > > 
> > > 
> 
> 
> 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: This is a digitally signed message part

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#113744): 
https://lists.openembedded.org/g/openembedded-devel/message/113744
Mute This Topic: https://lists.openembedded.org/mt/109402043/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to