Review: Abstain

Well this is spellingwise an improvement but judging by the code of the module 
it has bigger problems than this. None of the three fields that 
_membership_date can deliver share the same 'multi' argument, which neatly 
corresponds to the fact that this function only delivers only one field at the 
time! Personally I would like to see this cleaned up, but I am not the person 
to ask that of you. Maybe one of the core devs can confirm that they'd be 
interested in such a proposal?

I'll abstain for now as the spelling error is not visible for users and does 
not affect the functioning of the code as far as I can see.

-- 
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bugfix-membeship/+merge/141140
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/openobject-addons/trunk-bugfix-membeship.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Reply via email to