Review: Needs Fixing

Thanks for fixing the indent. As for my second remark, you put the account 
template records in a data tag with noupdate=True. You need the tag there for 
the account types. What you should do is close that data tag in l.159 and open 
another one in l.161 without the noupdate flag.

Please note that this only makes a difference in a very specific development 
scenario, in which you change a property of the templates and want to test the 
result. And even then there are other ways of forcing these records to reload. 
But there just is no reason for having the noupdate flag on these records.

-- 
https://code.launchpad.net/~openerp-community/openobject-addons/gscom-70-l10n-vn/+merge/141526
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/openobject-addons/gscom-70-l10n-vn.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Reply via email to