Review: Needs Fixing code review, no test
version in __openerp__.py : I'm not too fond of Sébastien's choice of using
6.1.0 in other related modules. I'd rather have a normal increment here.
s/add images against/add images to/
in field description:
s/Local mounted path on OpenERP server wheree all your images are stored./Local
directory on the OpenERP server where all images are stored/
s/add the posibility/add the possibility/
there are lots of vals.get('name', False) used as truth values, which can be
rewritten asn vals.get('name').
line 252: vals['name'] and vals['extension'] are garanteed to exist here, so no
need to use the get method. Possibly the case later in the write method.
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_images-migr/+merge/145630
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-community
More help : https://help.launchpad.net/ListHelp
