Review: Needs Information When you build a view yourself, you should call `openerp.osv.orm.setup_modifiers` on the nodes. (example in `account.wizard.account_report_common.account_common_report.fields_view_get`).
In your case, I don't think it will change anything, because it setup the modifiers for `attrs`, `states`, `invisible`, `readonly`, `required` and you don't use them. But I still think it would be proper to call it. What do you think? Nitpickings on the style: * The indentation of l.170,183,184 is a bit weird. * l.213,215 spaces around '=' -- https://code.launchpad.net/~akretion-team/openerp-product-attributes/mixin-extraction/+merge/151333 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. _______________________________________________ Mailing list: https://launchpad.net/~openerp-community Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
