Leonardo, I'm sorry if it seems abusive, but I don't think that it's normal even to not check the bug report within 6 months, but unfortunately OpenERP has many same bug reports without any answers. It's not good for commercial product. Especially when the bug explanation already includes the patch. At least they could set status and priority for the bug report and write something like "we agree, it designed bad. we'll try to fix it as soon as possible". Don't you think so?
What about email_re expression I'm also very surprising how people with "bad" emails like [email protected] worked with portal module until now? It's not a small trouble, it doesn't let people to work with portal, they can't dismiss it and continue to work. It's no problem for me to fix it with my OpenERP instance, but I guess all we want to help OpenERP S.A. to fix as more as possible bugs in official branch. But when someone added a bug explanation and still don't get any answer, it's not good workflow. Only with the best wishes, Denis. -- You received this bug notification because you are a member of OpenERP Community, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1199386 Title: Email address regular expression needs work Status in OpenERP Addons (modules): New Status in OpenERP Server: New Bug description: During testing with my email-address '[email protected]' I noticed a couple of things: 1. The partner contact with that email-address can't be given access to the portal by the portal wizard, it fails on creation of the user in addons/mail/res_user.py:68 : if not data.get('login', False): raise osv.except_osv(_('Invalid Action!'),...))) 2. The login field is empty, because the portal wizard uses the email field to create a login in addons/portal/wizard/portal_wizard.py:177 : 'login': extract_email(wizard_user.email), The extract_email function in portal_wizard.py uses 'email_re' to determine what the login field should look like. 'email_re' is defined as in multiple places, which is the first problem. It at least in tools/mail.py and tools/import_email.py. (The latter contains email information from the 'steel-sa.com ' (?!?) domain by the way.) email_re = re.compile(r""" ([a-zA-Z][\w\.-]*[a-zA-Z0-9] # username part @ # mandatory @ sign [a-zA-Z0-9][\w\.-]* # domain must start with a letter ... Ged> why do we include a 0-9 then? \. [a-z]{2,3} # TLD ) """, re.VERBOSE) Problems I see: 1. The email_re is defined in multiple places; make it one; 2. It forces to have email-addresses with at least 2 characters for the user part, of which the first must contain a letter; addresses like [email protected] won't work then; is there a reason for this? 3. the TLD must contain 2 or 3 characters, which is unsuitable for domains like .name or .info To manage notifications about this bug go to: https://bugs.launchpad.net/openobject-addons/+bug/1199386/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~openerp-community Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
