Review: Disapprove
This adds complexity and checks where they don't belong: there should be no 
need for these new arguments and things stored in session, no need for such 
modifications in root.py (if any), and the one thing which could be changed 
isn't: the xhr engine being more aware of things happening on the server and 
more involved in behavior implementation.

Parsing the referer also makes no sense, referers are not things you can rely 
on at any point and there should never be any need to use them.

I tried taking a stab at it, sending by mail.
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/login-server-restart/+merge/37841
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-client-web/login-server-restart.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to