Review: Resubmit * Adding popup does not seem to work at all, using Firefox or Safari on the branch (no merging between trunk and branch) clicking the add button (when it's made available/visible) opens a popup with only save/save and edit/close button, can't find a way to add a widget
* Also addition should be done via addition wizard (which might have to be fixed, not sure al finished it) * It should always be possible to add user widgets. * Logic for displaying widgets is incorrect: - Should only display widgets linked from `res.widget.user`, those with user_id=uid (that part is OK) *and* those with no user_id at all. Those with no user_id set can not be removed by the user (they are administrator-set and global). close_widget is not global. - Should not fallback on reading straight from res.widget * JS is imperfect and incorrect (if widget removal POST generates error, it still removes widgets from the interface which is not correct) Also needs demo data for testing: when demo data, * openerp favorites should be set as a global widget (in res.widget.user with user_id not set) * new widget for twitter of rvalyi should be set as user widget for the administrator * new widget for twitter of odo should be set as user widget for demo user That way it is possible to test that per user display works correctly. I would suggest throwing this branch away and re-doing. -- https://code.launchpad.net/~openerp-dev/openobject-client-web/widget-per-user/+merge/41128 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/widget-per-user. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
