Review: Disapprove
Mis-identified issue: the core problem is that the action is opened from the 
menu via a regular action and set as the current URL in openLink. The long-term 
fix is that link-setting should probably be done in doLoadingSuccess (and maybe 
loadingError, so the user can just Ctrl-R or Ctrl-F5 to reload a failed page?) 
rather than openLink (so we avoid setting the current URL to an action of 
target=new for instance).

This is just a work-around, it doesn't fix the actual problem (if you open the 
wizard, close it and then Ctrl-R or F5, it will reopen, and so it will break 
user history as well).

I also am not sure about the need to reload the backing view in case of a 
cancel. If it's a special=cancel button there is no server action being 
performed so I would think there's no need to reload the backing view.
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/pop-up-reopen/+merge/42907
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-client-web/pop-up-reopen.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to