Review: Needs Fixing Just tested it, and I see a few things that need to be improved before it can be merged:
- We need to hide the "server selection" widget when changing the user password, because it will confuse users (and is also more consistent with web-client implementation) - When the old password is not correct, the server throws an AccessDenied exception and this is ok. But when that happens the client displays an exception popup to the user. The client should at least catch the exceptions that can occur when calling change_password() and display a better message to the user (e.g using rpc.session.rpc_exec_auth_wo() + better error handling). + As an added bonus I think the client could compare the current session password with the "old password" provided, and ask the user to correct it without even sending to the server. + Also let's not close the popup when that happens, to allow the user to change the old password without retyping everything - When new password != confirmation password, there is a correct user message, but the change password popup is closed afterwards, forcing the user to re-type everything instead of simply correcting what's wrong. Let's not close the popup, same as when the old password is not correct. - Last one, it would be nice if the "Validate" button was the default, so pressing Enter key would submit the new password directly. I think that's all :-) -- https://code.launchpad.net/~openerp-commiter/openobject-client/passwd_change/+merge/45031 Your team OpenERP sa GTK client R&D is requested to review the proposed merge of lp:~openerp-commiter/openobject-client/passwd_change into lp:openobject-client. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
