Review: Needs Information
I disagree with this patch, even if it has already been merged.

On a technical side:
Is there any reason why you are not using a fields.related instead of a 
fields.boolean for storing this tracking status? First it requires no db schema 
change and second, it means the "tracking" field will have the correct value 
even when the form has just been (re)opened and the on_change has not fired yet.

On a functional side:
I'm not even sure this is a bug, as none of the Tracking checkboxes on a 
product mention anything about physical inventories. Therefore I wonder why 
this patch is based on "product.track_production" given that a physical 
inventory has nothing to do with a manufacturing order.
I think this needs to be discussed further before being applied... at the very 
least the tooltip of "product.track_production" should be modified.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-700928-ksa/+merge/54691
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to