Review: Needs Fixing
Hello Somesh,
Kindly check the following notes:
1. Line 60 of your merge, hour + 3 would break the test when it runs after
10-00.
2. Line 22. I am not 100% sure, but It is advisable to create a user rather
than linking an existing one.
3. Line 51 :Optimize the code by calling time.strftime('%Y-%m-%d %H:%M:%S'). It
will give you the same result.
4. Line 37-39. We may need date_to and we can achieve it by following
expression:
"(datetime.now()+timedelta(X)).strftime('%Y-%m-%d')" where X is the no. of days
for which you test the sheet.
5. About Line 9 : Won't it be fine to call specific fields to read rather than
[] on line 49 of yml?
data = self.pool.get('hr.timesheet.invoice.create').read(cr, uid,
[ref("hr_timesheet_invoice_create_0")], [FIELDS], context)[0]
Thanks.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-hr_timesheet_fix_yml-ara/+merge/59775
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-hr_timesheet_fix_yml-ara.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
