Review: Disapprove
1) things to be disappointed, how can you copy a certificate of an existing
module?
make sure that NEVER copy the certificate for new module
2) Put a proper module description, we have a good documentation for this on
the pad itself, you can refer to that (don't directly copy/paste it)
3) Put a proper module category, can be put under "Base"
4) Licence
5) I don't understand why you have created a "base.temporal.test" first and
then created "base.temporal.test.line" and again "base.temporal.test"
you can simplify the code...
6) This module never work on the other objects we want to be used as temporal
according to the spec, how, see below:
if we want to use temporal feature for any object, we need to use a simple
class inheritance (osv.osv_temporal)
in the code you have added all the required methods in "base.temporal.test"
so we need to inherit that object by _inherit = "base.temporal.test"
imagine you want res.partner as temporal, you need to do something like
this,
class temporal_partner(osv.osv_temporal):
_inherit = 'res_partner'
temporal_partner()
is there any chance to achieve this functionality in the code proposed?
well, there are many more things to check but I don't find any scope to test
them without fixing the problems listed,
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-temporal-db-branch-ksa/+merge/62871
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-temporal-db.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
