First pass, didn't look at the multi. - l.379: def __init__(self, skiparg=2, size=8192, multi=None, timeout=None): multi, timeout are unused
- Why the removal of context in some calls? - l.393: the clear function is unused. - l.400 and after: why the try/except instead of setdefault() or similar? Also, using ormcache as variable name in a ormcache class is not really nice. Could refactor the code as it is also used in clear(), or maybe it is not needed at all in clear(). - l.420: why would we have a type error (a comment would be nice). - l.472: I find the comment useful but you removed it. - The use of *args as the key prevent to use the cache on methods called with kwargs syntax I think. -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-cachecleanup/+merge/63807 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-cachecleanup. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
