Review: Needs Fixing hello, The merge proposal needs a lots of changes... its not good to change the signature of so many methods where as the task can be achieved without doing so. You created a list of fields while parsing the view then before creating widgets you checked for the count of the fields.. which needed so much of flow transformation. Instead you could do the same while parsing.
Secondly according to the diff the error message will always inform the user about the first duplicate field encountered but will never inform about the other fields if the view has more then 1 field as duplicates Also you need to pass in *common.message* method the *msg_to_xml* argument as True in order to replace the special characters "&", "<" and ">" to HTML-safe sequences. In diff: @ line no 9 you have remove *escape* function which is needed to replace special characters "&", "<" and ">" to HTML-safe sequences. Thanks, -- https://code.launchpad.net/~openerp-dev/openobject-client/trunk-bug-788098-rga/+merge/63980 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client/trunk-bug-788098-rga. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
