Review: Needs Fixing Nice, almost perfect now ;-) Could you also remove the useless second parameter for the get() at line 118 of the diff? And you may simplify a bit by replacing "obj._columns[field].relation" by "self._obj".
And one minor detail I didn't spot before: the postprocess() method takes a "user" param. I know some methods in ORM use 'user' instead of 'uid', but if possible we should keep 'uid' everywhere, for consistency (and it really is an ID, not a user object). Changing this for function.get() is risky because that would be renaming a keyword argument, but a least for a new method "postprocess()" we should stick to the convention. Sorry for the number of iterations, but this is the server API, so we need to be careful to continuously improve the code. Thanks! -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-781247-ysa/+merge/61933 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-bug-781247-ysa. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
