Review: Needs Fixing
after the improvement the report is working as expected,
but the approach to fix the problem is totally wrong,
don't hesitate to change the entire code you are dealing with if its wrong, but 
please don't make a small patches of wrong code that makes it working perfect,

20      + from mrp_production s
21      + left join mrp_production_product_line l on (s.id=l.id)

the join is not good, these both tables have not any one2one relation, so the 
checking is on id is not right
it seems like a compromise rather than a fix

please improve it,
thanks
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-787373-ksa/+merge/62658
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-787373-ksa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to